From: James Clark <james.clark@linaro.org>
To: Ian Rogers <irogers@google.com>, Leo Yan <leo.yan@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf docs: Mark the Android document as obsolete
Date: Tue, 16 Jul 2024 10:10:19 +0100 [thread overview]
Message-ID: <1e5aa1e1-e5c4-49bb-a43b-a119710a000c@linaro.org> (raw)
In-Reply-To: <CAP-5=fVd9pO7kKvZX7PZ6sJ+GHOV7aF=Ry98a=vknimuSTp9Lg@mail.gmail.com>
On 15/07/2024 6:17 pm, Ian Rogers wrote:
> On Mon, Jul 15, 2024 at 7:34 AM Leo Yan <leo.yan@arm.com> wrote:
> [snip]
>> +Android NDK compilation is deprecated and no longer supported.
>
> I think this is objectively worse than just removing the file. It is
Objectively worse is a bit strong. There was some discussion on the
previous version about the reasoning, but the point is to leave keywords
so that someone re-writing the NDK docs in the future can find it and
then the history will be preserved rather than putting it in a new file
with a new name. Or even someone wondering why their build command
doesn't work has at least something documented about it, even as a negative.
Of course this all depends on whether we decide the Android build
_should_ be working or not which looks like is also being discussed here.
> likely the perf tool can build with clang/LLVM, I do it every day, and
> the special case for Android is likely more about the libc (aka
> bionic) which gradually over time has been becoming more full fat -
> perhaps we need to carry somethings in tools/include for missing
> definitions, but we build with musl and that's a PITA in this regard,
> we've also been reducing the tools/include dependencies for perf trace
> beauty support. We don't use ifuncs in the perf tool (Android's
> linker/loader historically hasn't supported these) and the weak symbol
> games should be okay and something I aspire to make less in the perf
> tool over time. As Android uses Linux then it should work and should
> be supported.
>
> Thanks,
> Ian
next prev parent reply other threads:[~2024-07-16 9:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 14:33 [PATCH v2] perf docs: Mark the Android document as obsolete Leo Yan
2024-07-15 15:29 ` James Clark
2024-07-15 17:17 ` Ian Rogers
2024-07-15 19:31 ` Leo Yan
2024-07-15 19:44 ` Ian Rogers
2024-07-15 20:06 ` Ian Rogers
2024-07-15 20:36 ` Leo Yan
2024-07-15 21:21 ` Ian Rogers
2024-07-16 10:06 ` Leo Yan
2024-07-16 13:30 ` Ian Rogers
2024-07-16 13:49 ` Leo Yan
2024-07-16 15:05 ` Ian Rogers
2024-07-16 15:41 ` Leo Yan
2024-07-15 20:10 ` Leo Yan
2024-07-16 9:10 ` James Clark [this message]
2024-07-16 10:40 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e5aa1e1-e5c4-49bb-a43b-a119710a000c@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox