* [PATCH] nls: Fix utf32_to_utf8 parameter type in declaration and definition
@ 2025-03-13 8:01 ye.xingchen
2025-03-13 15:52 ` Jeff Johnson
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2025-03-13 8:01 UTC (permalink / raw)
To: brauner; +Cc: jack, jeff.johnson, linux-kernel
From: YeXingchen <ye.xingchen@zte.com.cn>
The declaration of utf32_to_utf8 in the header file uses
bool maxlen as the parameter type, while the definition uses bool maxout.
This patch aligns the parameter name in the definition with the
declaration,changing maxout to maxlen to ensure consistency.
Signed-off-by: YeXingchen <ye.xingchen@zte.com.cn>
---
fs/nls/nls_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nls/nls_base.c b/fs/nls/nls_base.c
index 18d597e49a19..1dc2f8c8916e 100644
--- a/fs/nls/nls_base.c
+++ b/fs/nls/nls_base.c
@@ -83,7 +83,7 @@ int utf8_to_utf32(const u8 *s, int inlen, unicode_t *pu)
}
EXPORT_SYMBOL(utf8_to_utf32);
-int utf32_to_utf8(unicode_t u, u8 *s, int maxout)
+int utf32_to_utf8(unicode_t u, u8 *s, int maxlen)
{
unsigned long l;
int c, nc;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] nls: Fix utf32_to_utf8 parameter type in declaration and definition
2025-03-13 8:01 [PATCH] nls: Fix utf32_to_utf8 parameter type in declaration and definition ye.xingchen
@ 2025-03-13 15:52 ` Jeff Johnson
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Johnson @ 2025-03-13 15:52 UTC (permalink / raw)
To: ye.xingchen, brauner; +Cc: jack, linux-kernel
On 3/13/2025 1:01 AM, ye.xingchen@zte.com.cn wrote:
> From: YeXingchen <ye.xingchen@zte.com.cn>
>
> The declaration of utf32_to_utf8 in the header file uses
> bool maxlen as the parameter type, while the definition uses bool maxout.
>
> This patch aligns the parameter name in the definition with the
> declaration,changing maxout to maxlen to ensure consistency.
>
> Signed-off-by: YeXingchen <ye.xingchen@zte.com.cn>
> ---
> fs/nls/nls_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nls/nls_base.c b/fs/nls/nls_base.c
> index 18d597e49a19..1dc2f8c8916e 100644
> --- a/fs/nls/nls_base.c
> +++ b/fs/nls/nls_base.c
> @@ -83,7 +83,7 @@ int utf8_to_utf32(const u8 *s, int inlen, unicode_t *pu)
> }
> EXPORT_SYMBOL(utf8_to_utf32);
>
> -int utf32_to_utf8(unicode_t u, u8 *s, int maxout)
> +int utf32_to_utf8(unicode_t u, u8 *s, int maxlen)
> {
> unsigned long l;
> int c, nc;
It is obvious you didn't compile this code since the implementation still uses
maxout. Note that a less intrusive change would be to rename parameters in the
prototype.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-13 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-13 8:01 [PATCH] nls: Fix utf32_to_utf8 parameter type in declaration and definition ye.xingchen
2025-03-13 15:52 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox