From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen-Yu Tsai <wens@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH v2 3/3] regulator: axp20x: add support for the AXP318W
Date: Sat, 11 Jul 2026 14:37:11 +0200 [thread overview]
Message-ID: <1jmrvxg0so.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <befcd3cb-3452-48f5-93e6-03210981bd76@sirena.org.uk> (Mark Brown's message of "Fri, 10 Jul 2026 18:00:24 +0100")
On ven. 10 juil. 2026 at 18:00, Mark Brown <broonie@kernel.org> wrote:
> On Fri, Jul 10, 2026 at 06:19:27PM +0200, Jerome Brunet wrote:
>
>> +#define AXP_DESC_RANGES_DELAY_OPS(_family, _id, _match, _supply, _ranges, \
>> + _n_voltages, _vreg, _vmask, _ereg, _emask, \
>> + _ramp_delay, _ops) \
>> [_family##_##_id] = { \
>> .name = (_match), \
>> .supply_name = (_supply), \
>> @@ -436,10 +481,23 @@
>> .enable_mask = (_emask), \
>> .linear_ranges = (_ranges), \
>> .n_linear_ranges = ARRAY_SIZE(_ranges), \
>> - .ramp_delay = (_ramp_delay), \
>> + .ramp_delay = (_ramp_delay), \
>> .ops = &axp20x_ops_range, \
>
> This macro takes but ignores an ops parameter.
Indeed, completely messed up as noted in reply to the cover
letter. Sorry about that. Tested something, sent something else (and
other mistakes ...)
--
Jerome
next prev parent reply other threads:[~2026-07-11 12:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 16:19 [PATCH v2 0/3] regulator: Add X-Powers AXP318W PMIC support Jerome Brunet
2026-07-10 16:19 ` [PATCH v2 1/3] dt-bindings: mfd: x-powers,axp152: Document AXP318W Jerome Brunet
2026-07-10 16:19 ` [PATCH v2 2/3] mfd: axp20x: Add support for AXP318W PMIC Jerome Brunet
2026-07-10 16:19 ` [PATCH v2 3/3] regulator: axp20x: add support for the AXP318W Jerome Brunet
2026-07-10 16:27 ` Jerome Brunet
2026-07-10 17:00 ` Mark Brown
2026-07-11 12:37 ` Jerome Brunet [this message]
2026-07-10 17:02 ` [PATCH v2 0/3] regulator: Add X-Powers AXP318W PMIC support Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jmrvxg0so.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox