public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: reset_xmit_timer errors with 2.4.0
@ 2001-01-06  0:49 David S. Miller
  2001-01-06  2:41 ` Patrick Michael Kane
  0 siblings, 1 reply; 4+ messages in thread
From: David S. Miller @ 2001-01-06  0:49 UTC (permalink / raw)
  To: misiek; +Cc: linux-kernel

   Date: 	Fri, 5 Jan 2001 19:22:39 +0100
   From: Arkadiusz Miskiewicz <misiek@pld.ORG.PL>

   On/Dnia Fri, Jan 05, 2001 at 06:52:52AM -0800, Patrick Michael Kane wrote
   > With 2.4.0 installed, I've started to see the following errors:
   > 
   > reset_xmit_timer sk=cfd889a0 1 when=0x3b4a, caller=c01e0748
   > reset_xmit_timer sk=cfd889a0 1 when=0x3a80, caller=c01e0748
   >

   the same problem here

Does the following patch fix this for people?

--- net/ipv4/tcp_input.c.~1~	Wed Dec 13 10:31:48 2000
+++ net/ipv4/tcp_input.c	Fri Jan  5 17:01:53 2001
@@ -1705,7 +1705,7 @@
 
 		if ((__s32)when < (__s32)tp->rttvar)
 			when = tp->rttvar;
-		tcp_reset_xmit_timer(sk, TCP_TIME_RETRANS, when);
+		tcp_reset_xmit_timer(sk, TCP_TIME_RETRANS, min(when, TCP_RTO_MAX));
 	}
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 4+ messages in thread
* reset_xmit_timer errors with 2.4.0
@ 2001-01-05 14:52 Patrick Michael Kane
  2001-01-05 18:22 ` Arkadiusz Miskiewicz
  0 siblings, 1 reply; 4+ messages in thread
From: Patrick Michael Kane @ 2001-01-05 14:52 UTC (permalink / raw)
  To: linux-kernel

Hello!

I've installed 2.4.0 on a system that has been tracking 2.3.xx/2.4test for
quite a while.  With 2.4.0 installed, I've started to see the following
errors:

reset_xmit_timer sk=cfd889a0 1 when=0x3b4a, caller=c01e0748
reset_xmit_timer sk=cfd889a0 1 when=0x3a80, caller=c01e0748
reset_xmit_timer sk=cfd889a0 1 when=0x398a, caller=c01e0748
reset_xmit_timer sk=cfd889a0 1 when=0x389e, caller=c01e0748
reset_xmit_timer sk=cfd889a0 1 when=0x37b6, caller=c01e0748

It's a UP system with no kernel patches, running an eepro100 card.  I did
not get these errors under any of the 2.4test kernels.  Should I be worried?

Best,
-- 
Patrick Michael Kane
<modus@pr.es.to>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2001-01-06  2:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-01-06  0:49 reset_xmit_timer errors with 2.4.0 David S. Miller
2001-01-06  2:41 ` Patrick Michael Kane
  -- strict thread matches above, loose matches on Subject: below --
2001-01-05 14:52 Patrick Michael Kane
2001-01-05 18:22 ` Arkadiusz Miskiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox