[Patch] [linux-2.4.0] drivers/usb/Config.in

[Patch] [linux-2.4.0] drivers/usb/Config.in

[Nicolas Mailhot]

[Re-send without the mime stuff, sorry about this one]

Hi,

 Here is a patchlet to stop people searching for the
mysteriously hidden USB Mass Storage driver (in case they
didn't make the connection with SCSI at once like me).

 Seems to work, and anyway I don't see how I could have
messed up this one:)

 Regards,

--- linux-2.4.0/drivers/usb/Config.in	Tue Nov 28 03:10:35 2000
+++ linux-2.4.0-nim1/drivers/usb/Config.in	Sat Jan  6 18:04:26 2001
@@ -28,10 +28,14 @@
    comment 'USB Device Class drivers'
    dep_tristate '  USB Audio support' CONFIG_USB_AUDIO $CONFIG_USB $CONFIG_SOUND
    dep_tristate '  USB Bluetooth support (EXPERIMENTAL)' CONFIG_USB_BLUETOOTH $CONFIG_USB $CONFIG_EXPERIMENTAL
-   dep_tristate '  USB Mass Storage support' CONFIG_USB_STORAGE $CONFIG_USB $CONFIG_SCSI
-   if [ "$CONFIG_USB_STORAGE" != "n" ]; then
-      bool '    USB Mass Storage verbose debug' CONFIG_USB_STORAGE_DEBUG
-      bool '    Freecom USB/ATAPI Bridge support' CONFIG_USB_STORAGE_FREECOM
+   if [ "$CONFIG_SCSI" = "n" ]; then
+      comment '  SCSI support is needed for USB Mass Storage'
+   else
+      dep_tristate '  USB Mass Storage support' CONFIG_USB_STORAGE $CONFIG_USB $CONFIG_SCSI
+      if [ "$CONFIG_USB_STORAGE" != "n" ]; then
+         bool '    USB Mass Storage verbose debug' CONFIG_USB_STORAGE_DEBUG
+         bool '    Freecom USB/ATAPI Bridge support' CONFIG_USB_STORAGE_FREECOM
+      fi
    fi
    dep_tristate '  USB Modem (CDC ACM) support' CONFIG_USB_ACM $CONFIG_USB
    dep_tristate '  USB Printer support' CONFIG_USB_PRINTER $CONFIG_USB


-- 
Nicolas Mailhot

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [Patch] [linux-2.4.0] drivers/usb/Config.in

[Greg KH]

On Sun, Jan 07, 2001 at 02:04:40PM +0100, Nicolas Mailhot wrote:
> [Re-send without the mime stuff, sorry about this one]
> 
> Hi,
> 
>  Here is a patchlet to stop people searching for the
> mysteriously hidden USB Mass Storage driver (in case they
> didn't make the connection with SCSI at once like me).

I wouldn't recommend this one.  If you do this, should we do the same
for all of the other dependencies in the USB config section?  Like
VIDEO, SOUND, and others?  That would make for a _big_ mess.

greg k-h

-- 
greg@(kroah|wirex).com
http://immunix.org/~greg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [Patch] [linux-2.4.0] drivers/usb/Config.in

[Nicolas Mailhot]

Le dim, 07 jan 2001 18:37:11, Greg KH a écrit :
> On Sun, Jan 07, 2001 at 02:04:40PM +0100, Nicolas Mailhot wrote:

> >  Here is a patchlet to stop people searching for the
> > mysteriously hidden USB Mass Storage driver (in case they
> > didn't make the connection with SCSI at once like me).
> 
> I wouldn't recommend this one.  If you do this, should we do the same
> for all of the other dependencies in the USB config section?  Like
> VIDEO, SOUND, and others?  That would make for a _big_ mess.

Well, it's certainly not the first patch of this kind to
make it into the USB config file (see input core), so if a
precedant was set, it wasn't by this patch. Do we need to do
this for every dependency ? I don't know, IMHO only for the
non obvious ones (and anyway, that's just a bit of
documentation, what's wrong with having more doc ?)

And the dependency between USB Mass Storage and SCSI support
is more than sufficiently obscure for the end-user to
justify this one. Comme on, who -- appart from the driver
developpers -- would think of it at once by itself ? I do
know I spent almost more time searching for the Mass Storage
driver option than writing/testing this patch, since I've
got a SCSI-less system.

Knowing that something requires VIDEO or SOUND, on the other
hand, do not requires deep knowledge of the driver sources.

Regards,

-- 
Nicolas Mailhot

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/