From: Robert Read <rread@datarithm.net>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Re: kernel/printk.c: increasing the buffer size to capture devfsd debug messages.
Date: Tue, 20 Feb 2001 12:17:27 -0800 [thread overview]
Message-ID: <20010220121727.B4106@tenchi.datarithm.net> (raw)
In-Reply-To: <3A92A99E.2F255CB3@yk.rim.or.jp> <20010220111542.A4106@tenchi.datarithm.net> <3A92C76C.6519DF1A@cypress.com>
In-Reply-To: <3A92C76C.6519DF1A@cypress.com>; from ted@cypress.com on Tue, Feb 20, 2001 at 01:37:16PM -0600
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
On Tue, Feb 20, 2001 at 01:37:16PM -0600, Thomas Dodd wrote:
> Robert Read wrote:
> >
> > On Wed, Feb 21, 2001 at 02:30:08AM +0900, Ishikawa wrote:
> > >
> > > Has anyone tried 128K buffer size in kernel/printk.c
> > > and still have the kernel boot (without
> > > hard to notice memory corruption problems and other subtle bugs)?
> > > Any hints and tips will be appreciated.
> >
> > I have used 128k and larger buffer sizes, and I just noticed this
> > fragment in the RedHat Tux Webserver patch. It creates a 2MB buffer:
>
> I think this should be a config option.
Ok, here is a simple patch to add a config option, I'm compiling it
now, so it's not tested yet. One question: what is the best way to
force this option to be a power of 2?
robert
[-- Attachment #2: printk-buflen.patch --]
[-- Type: text/plain, Size: 1122 bytes --]
diff -ru linux-2.4.2-pre4/arch/i386/config.in linux-2.4.2-pre4-logbuf/arch/i386/config.in
--- linux-2.4.2-pre4/arch/i386/config.in Mon Jan 8 13:27:56 2001
+++ linux-2.4.2-pre4-logbuf/arch/i386/config.in Tue Feb 20 12:10:19 2001
@@ -366,4 +366,5 @@
#bool 'Debug kmalloc/kfree' CONFIG_DEBUG_MALLOC
bool 'Magic SysRq key' CONFIG_MAGIC_SYSRQ
+int 'Printk buffer size (must be power of 2)' CONFIG_PRINTK_BUF_LEN 16384
endmenu
Only in linux-2.4.2-pre4-logbuf/arch/i386: config.in~
Only in linux-2.4.2-pre4-logbuf/include: asm
Only in linux-2.4.2-pre4-logbuf/include/linux: autoconf.h
Only in linux-2.4.2-pre4-logbuf/include/linux: modules
diff -ru linux-2.4.2-pre4/kernel/printk.c linux-2.4.2-pre4-logbuf/kernel/printk.c
--- linux-2.4.2-pre4/kernel/printk.c Tue Feb 20 11:56:31 2001
+++ linux-2.4.2-pre4-logbuf/kernel/printk.c Tue Feb 20 11:59:35 2001
@@ -23,7 +23,11 @@
#include <asm/uaccess.h>
-#define LOG_BUF_LEN (16384)
+#ifdef CONFIG_PRINTK_BUF_LEN
+# define LOG_BUF_LEN (CONFIG_PRINTK_BUF_LEN)
+#else
+# define LOG_BUF_LEN (16384)
+#endif
#define LOG_BUF_MASK (LOG_BUF_LEN-1)
static char buf[1024];
next prev parent reply other threads:[~2001-02-20 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-20 17:30 kernel/printk.c: increasing the buffer size to capture devfsd debug messages Ishikawa
2001-02-20 19:15 ` Robert Read
2001-02-20 19:37 ` Thomas Dodd
2001-02-20 20:17 ` Robert Read [this message]
2001-02-20 20:53 ` [PATCH] " Thomas Dodd
2001-02-20 21:03 ` Thomas Dodd
2001-02-20 22:05 ` Robert Read
2001-02-20 22:17 ` [PATCH] configurable printk buffer size Robert Read
2001-02-20 21:27 ` kernel/printk.c: increasing the buffer size to capture devfsd debug messages Ishikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010220121727.B4106@tenchi.datarithm.net \
--to=rread@datarithm.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox