From: Thomas Dodd <ted@cypress.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: kernel/printk.c: increasing the buffer size to capture devfsd debug messages.
Date: Tue, 20 Feb 2001 15:03:27 -0600 [thread overview]
Message-ID: <3A92DB9F.28DF79F1@cypress.com> (raw)
In-Reply-To: <3A92A99E.2F255CB3@yk.rim.or.jp> <20010220111542.A4106@tenchi.datarithm.net> <3A92C76C.6519DF1A@cypress.com> <20010220121727.B4106@tenchi.datarithm.net> <3A92D930.6F11B505@cypress.com>
Thomas Dodd wrote:
>
> Robert Read wrote:
> >
> > Ok, here is a simple patch to add a config option, I'm compiling it
> > now, so it's not tested yet. One question: what is the best way to
> > force this option to be a power of 2?
>
> Why not just make the config option in Kbytes.
> and do:
>
> #define LOG_BUF_LEN (CONFIG_PRINTK_BUF_LEN * 1024)
>
> since the config option has a default option and will
> always be defined, is the #ifdef check really needed?
Oops...
It's not needed if all arch's have the config option added.
Only parisc uses a different file, config.common instead of config.in
Would this break any thing?
-Thomas
next prev parent reply other threads:[~2001-02-20 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-20 17:30 kernel/printk.c: increasing the buffer size to capture devfsd debug messages Ishikawa
2001-02-20 19:15 ` Robert Read
2001-02-20 19:37 ` Thomas Dodd
2001-02-20 20:17 ` [PATCH] " Robert Read
2001-02-20 20:53 ` Thomas Dodd
2001-02-20 21:03 ` Thomas Dodd [this message]
2001-02-20 22:05 ` Robert Read
2001-02-20 22:17 ` [PATCH] configurable printk buffer size Robert Read
2001-02-20 21:27 ` kernel/printk.c: increasing the buffer size to capture devfsd debug messages Ishikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A92DB9F.28DF79F1@cypress.com \
--to=ted@cypress.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox