* [PATCH] Fix compile of drivers/pci/pci.c in 2.4.9-pre2
@ 2001-08-13 15:31 Tom Rini
2001-08-13 15:37 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2001-08-13 15:31 UTC (permalink / raw)
To: Linus Torvalds, Alan Cox; +Cc: linux-kernel
Hello. 2.4.9-pre2 introduced the mandatory PM transition delays for PCI
devices. However, it currently doesn't compile, at least on PPC, since
drivers/pci/pci.c doesn't include <asm/delay.h> to get the definition of
udelay. Please apply this to the next release. Thanks.
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
===== drivers/pci/pci.c 1.17 vs edited =====
--- 1.17/drivers/pci/pci.c Sun Aug 12 23:55:22 2001
+++ edited/drivers/pci/pci.c Mon Aug 13 08:25:35 2001
@@ -25,6 +25,7 @@
#include <asm/page.h>
#include <asm/dma.h> /* isa_dma_bridge_buggy */
+#include <asm/delay.h> /* for udelay */
#undef DEBUG
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix compile of drivers/pci/pci.c in 2.4.9-pre2
2001-08-13 15:31 [PATCH] Fix compile of drivers/pci/pci.c in 2.4.9-pre2 Tom Rini
@ 2001-08-13 15:37 ` David S. Miller
2001-08-13 15:46 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2001-08-13 15:37 UTC (permalink / raw)
To: trini; +Cc: torvalds, alan, linux-kernel
From: Tom Rini <trini@kernel.crashing.org>
Date: Mon, 13 Aug 2001 08:31:00 -0700
Hello. 2.4.9-pre2 introduced the mandatory PM transition delays for PCI
devices. However, it currently doesn't compile, at least on PPC, since
drivers/pci/pci.c doesn't include <asm/delay.h> to get the definition of
udelay. Please apply this to the next release. Thanks.
The correct include is <linux/delay.h> not <asm/delay.h>
Later,
David S. Miller
davem@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix compile of drivers/pci/pci.c in 2.4.9-pre2
2001-08-13 15:37 ` David S. Miller
@ 2001-08-13 15:46 ` Tom Rini
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rini @ 2001-08-13 15:46 UTC (permalink / raw)
To: David S. Miller; +Cc: torvalds, alan, linux-kernel
On Mon, Aug 13, 2001 at 08:37:47AM -0700, David S. Miller wrote:
> From: Tom Rini <trini@kernel.crashing.org>
> Date: Mon, 13 Aug 2001 08:31:00 -0700
>
> Hello. 2.4.9-pre2 introduced the mandatory PM transition delays for PCI
> devices. However, it currently doesn't compile, at least on PPC, since
> drivers/pci/pci.c doesn't include <asm/delay.h> to get the definition of
> udelay. Please apply this to the next release. Thanks.
>
> The correct include is <linux/delay.h> not <asm/delay.h>
Ah, whoops.
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-08-13 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-08-13 15:31 [PATCH] Fix compile of drivers/pci/pci.c in 2.4.9-pre2 Tom Rini
2001-08-13 15:37 ` David S. Miller
2001-08-13 15:46 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox