From: "David S. Miller" <davem@redhat.com>
To: zippel@linux-m68k.org
Cc: aia21@cam.ac.uk, tpepper@vato.org, f5ibh@db0bm.ampr.org,
linux-kernel@vger.kernel.org
Subject: Re: 2.4.9 does not compile [PATCH]
Date: Thu, 16 Aug 2001 20:13:42 -0700 (PDT) [thread overview]
Message-ID: <20010816.201342.99205586.davem@redhat.com> (raw)
In-Reply-To: <3B7C8AB8.19BF8425@linux-m68k.org>
In-Reply-To: <3B7C8196.10D1C867@linux-m68k.org> <20010816.193841.98557608.davem@redhat.com> <3B7C8AB8.19BF8425@linux-m68k.org>
From: Roman Zippel <zippel@linux-m68k.org>
Date: Fri, 17 Aug 2001 05:08:40 +0200
BTW I just looked through the patch and I only found a single cast, so
there was not much need for such dumb casts. Your patch now forced the
cast into all of them...
The cast in the new version is not dumb, it's smart.
It's the programmer saying (to both the reader of the
code and the compiler) "I want this comparison to use
type X". Period.
There is no ambiguity, there are no multiple-evaluation
issues, and no dumb warnings from the compiler.
Later,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-08-17 3:17 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-16 21:11 2.4.9 does not compile f5ibh
2001-08-16 21:41 ` 2.4.9 does not compile [PATCH] tpepper
2001-08-16 22:31 ` David S. Miller
2001-08-16 23:13 ` Daniel Phillips
2001-08-16 23:11 ` David S. Miller
2001-08-16 23:14 ` Alan Cox
2001-08-16 23:35 ` Anton Altaparmakov
2001-08-16 23:40 ` David S. Miller
[not found] ` <Pine.LNX.4.33L.0108171844000.2277-100000@duckman.distro.conectiva>
2001-08-17 21:58 ` David S. Miller
2001-08-17 1:46 ` Jeff Dike
[not found] ` <Your message of "Fri, 17 Aug 2001 00:35:02 +0100." <5.1.0.14.2.20010817002825.00b1e4e0@pop.cus.cam.ac.uk>
2001-08-17 1:22 ` Anton Altaparmakov
2001-08-17 1:49 ` Andrew Morton
2001-08-17 1:53 ` David S. Miller
2001-08-17 2:05 ` Daniel Phillips
2001-08-17 3:55 ` Jeff Dike
2001-08-17 17:30 ` Rik van Riel
2001-08-16 23:22 ` Anton Altaparmakov
2001-08-16 23:38 ` David S. Miller
2001-08-17 1:24 ` Roman Zippel
2001-08-17 1:50 ` David S. Miller
2001-08-17 2:29 ` Roman Zippel
2001-08-17 2:38 ` David S. Miller
2001-08-17 2:53 ` Roman Zippel
2001-08-17 2:59 ` David S. Miller
2001-08-17 3:23 ` Roman Zippel
2001-08-17 3:37 ` David S. Miller
2001-08-17 3:59 ` Roman Zippel
2001-08-17 8:35 ` Anton Altaparmakov
2001-08-17 4:29 ` Ben LaHaise
2001-08-17 6:07 ` David S. Miller
2001-08-17 3:08 ` Roman Zippel
2001-08-17 3:13 ` David S. Miller [this message]
2001-08-17 3:39 ` Roman Zippel
2001-08-17 3:44 ` David S. Miller
2001-08-16 22:10 ` 2.4.9 does not compile [better PATCH] tpepper
2001-08-16 22:21 ` 2.4.9 does not compile [PATCH] Anton Altaparmakov
2001-08-16 22:28 ` 2.4.9 does not compile [better PATCH] Anton Altaparmakov
2001-08-17 4:23 ` Jeff Chua
2001-08-17 1:06 ` 2.4.9 does not compile (adaptec new driver) Luigi Genoni
[not found] <Your message of "Fri, 17 Aug 2001 00:35:02 +0100." <5.1.0.14.2.20010817002825.00b1e4e0@pop.cus.cam.ac.uk.suse.lists.linux.kernel>
[not found] ` <5.1.0.14.2.20010817015007.045689b0@pop.cus.cam.ac.uk.suse.lists.linux.kernel>
[not found] ` <3B7C7846.FD9DEE68@zip.com.au.suse.lists.linux.kernel>
[not found] ` <20010816.185319.88475216.davem@redhat.com.suse.lists.linux.kernel>
2001-08-17 7:30 ` 2.4.9 does not compile [PATCH] Andi Kleen
[not found] <no.id>
2001-08-16 22:41 ` Alan Cox
2001-08-16 22:48 ` David S. Miller
2001-08-17 21:12 ` Jes Sorensen
2001-08-16 22:55 ` Alan Cox
2001-08-16 23:02 ` David S. Miller
[not found] ` <Pine.LNX.4.33L.0108171845570.2277-100000@duckman.distro.conectiva>
2001-08-17 21:59 ` David S. Miller
2001-08-16 23:08 ` Alan Cox
2001-08-17 9:11 ` Alan Cox
2001-08-17 20:57 ` David S. Miller
2001-08-17 9:17 ` Alan Cox
2001-08-17 9:25 ` Alan Cox
2001-08-17 21:40 ` Alan Cox
2001-08-17 22:09 ` Alan Cox
2001-08-17 22:11 ` David S. Miller
2001-08-17 23:34 ` Daniel Phillips
2001-08-17 23:38 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010816.201342.99205586.davem@redhat.com \
--to=davem@redhat.com \
--cc=aia21@cam.ac.uk \
--cc=f5ibh@db0bm.ampr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tpepper@vato.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox