public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.9 does not compile [PATCH]
Date: 17 Aug 2001 09:30:18 +0200	[thread overview]
Message-ID: <oupofpfw3cl.fsf@pigdrop.muc.suse.de> (raw)
In-Reply-To: <Your message of "Fri, 17 Aug 2001 00:35:02 +0100."  <5.1.0.14.2.20010817002825.00b1e4e0@pop.cus.cam.ac.uk.suse.lists.linux.kernel> <5.1.0.14.2.20010817015007.045689b0@pop.cus.cam.ac.uk.suse.lists.linux.kernel> <3B7C7846.FD9DEE68@zip.com.au.suse.lists.linux.kernel> <20010816.185319.88475216.davem@redhat.com.suse.lists.linux.kernel>
In-Reply-To: "David S. Miller"'s message of "17 Aug 2001 03:59:36 +0200"

"David S. Miller" <davem@redhat.com> writes:

>    From: Andrew Morton <akpm@zip.com.au>
>    Date: Thu, 16 Aug 2001 18:49:58 -0700
> 
>    int test(int __x, int __y)
>    {
>            return min(__x, __y);		/* sic */
>    }
> 
> People are expected not to use underscore prefixed
> variables in normal C code, this is why macros
> in the kernel make liberal use of them for locals.

You are joking, right?  The kernel is full of double under score prefixed
identifiers, for functions that do slighter lower level things than others.
While this expectation may exist in POSIX/C89 and is frequently violated there,
in kernel C nobody cares about it at all.

It doesn't matter anyways, the way C macro expansion works guarantees that
only macro arguments written in the macro get expanded; the arguments are not
recursively expanded. Therefore any games with "magic" macro names 
is totally unnecessary.

-Andi

       reply	other threads:[~2001-08-17  8:43 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Your message of "Fri, 17 Aug 2001 00:35:02 +0100."  <5.1.0.14.2.20010817002825.00b1e4e0@pop.cus.cam.ac.uk.suse.lists.linux.kernel>
     [not found] ` <5.1.0.14.2.20010817015007.045689b0@pop.cus.cam.ac.uk.suse.lists.linux.kernel>
     [not found]   ` <3B7C7846.FD9DEE68@zip.com.au.suse.lists.linux.kernel>
     [not found]     ` <20010816.185319.88475216.davem@redhat.com.suse.lists.linux.kernel>
2001-08-17  7:30       ` Andi Kleen [this message]
     [not found] <no.id>
2001-08-16 22:41 ` 2.4.9 does not compile [PATCH] Alan Cox
2001-08-16 22:48   ` David S. Miller
2001-08-17 21:12     ` Jes Sorensen
2001-08-16 22:55 ` Alan Cox
2001-08-16 23:02   ` David S. Miller
     [not found]     ` <Pine.LNX.4.33L.0108171845570.2277-100000@duckman.distro.conectiva>
2001-08-17 21:59       ` David S. Miller
2001-08-16 23:08 ` Alan Cox
2001-08-17  9:11 ` Alan Cox
2001-08-17 20:57   ` David S. Miller
2001-08-17  9:17 ` Alan Cox
2001-08-17  9:25 ` Alan Cox
2001-08-17 21:40 ` Alan Cox
2001-08-17 22:09 ` Alan Cox
2001-08-17 22:11   ` David S. Miller
2001-08-17 23:34     ` Daniel Phillips
2001-08-17 23:38       ` David S. Miller
2001-08-16 21:11 2.4.9 does not compile f5ibh
2001-08-16 21:41 ` 2.4.9 does not compile [PATCH] tpepper
2001-08-16 22:31   ` David S. Miller
2001-08-16 23:13     ` Daniel Phillips
2001-08-16 23:11       ` David S. Miller
2001-08-16 23:14       ` Alan Cox
2001-08-16 23:35       ` Anton Altaparmakov
2001-08-16 23:40         ` David S. Miller
     [not found]           ` <Pine.LNX.4.33L.0108171844000.2277-100000@duckman.distro.conectiva>
2001-08-17 21:58             ` David S. Miller
2001-08-17  1:46         ` Jeff Dike
     [not found]           ` <Your message of "Fri, 17 Aug 2001 00:35:02 +0100." <5.1.0.14.2.20010817002825.00b1e4e0@pop.cus.cam.ac.uk>
2001-08-17  1:22             ` Anton Altaparmakov
2001-08-17  1:49               ` Andrew Morton
2001-08-17  1:53                 ` David S. Miller
2001-08-17  2:05                 ` Daniel Phillips
2001-08-17  3:55               ` Jeff Dike
2001-08-17 17:30     ` Rik van Riel
2001-08-16 23:22   ` Anton Altaparmakov
2001-08-16 23:38     ` David S. Miller
2001-08-17  1:24       ` Roman Zippel
2001-08-17  1:50         ` David S. Miller
2001-08-17  2:29           ` Roman Zippel
2001-08-17  2:38             ` David S. Miller
2001-08-17  2:53               ` Roman Zippel
2001-08-17  2:59                 ` David S. Miller
2001-08-17  3:23                   ` Roman Zippel
2001-08-17  3:37                     ` David S. Miller
2001-08-17  3:59                       ` Roman Zippel
2001-08-17  8:35                       ` Anton Altaparmakov
2001-08-17  4:29                   ` Ben LaHaise
2001-08-17  6:07                     ` David S. Miller
2001-08-17  3:08               ` Roman Zippel
2001-08-17  3:13                 ` David S. Miller
2001-08-17  3:39                   ` Roman Zippel
2001-08-17  3:44                     ` David S. Miller
2001-08-16 22:21 ` Anton Altaparmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=oupofpfw3cl.fsf@pigdrop.muc.suse.de \
    --to=ak@suse.de \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox