From: David Weinehall <tao@acc.umu.se>
To: Kapr Johnik <kapr.johnik@seznam.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH-2.2.19] bug in cs89x0
Date: Wed, 26 Sep 2001 00:47:55 +0200 [thread overview]
Message-ID: <20010926004755.A968@khan.acc.umu.se> (raw)
In-Reply-To: <3BB03C3E.3080906@seznam.cz>
In-Reply-To: <3BB03C3E.3080906@seznam.cz>; from kapr.johnik@seznam.cz on Tue, Sep 25, 2001 at 10:11:42AM +0200
On Tue, Sep 25, 2001 at 10:11:42AM +0200, Kapr Johnik wrote:
> Hi to all.
>
> I think I've found bug in the cs89x0 network driver in 2.2.19, which we
> are using in an embedded network router. The driver does not use
> skb_put(), instead it writes directly to skb->len and leaves skb->tail
> incorrect. Patch follows.
The same error exists in the v2.4-kernel, drivers/net/mac89x0.c
/David Weinehall
--- linux-2.4.10/drivers/net/mac89x0.c.old Wed Sep 26 00:45:44 2001
+++ linux-2.4.10/drivers/net/mac89x0.c Wed Sep 26 00:46:34 2001
@@ -524,7 +524,7 @@
lp->stats.rx_dropped++;
return;
}
- skb->len = length;
+ skb_put(skb, length);
skb->dev = dev;
memcpy_fromio(skb->data, dev->mem_start + PP_RxFrame, length);
prev parent reply other threads:[~2001-09-25 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-25 8:11 [PATCH-2.2.19] bug in cs89x0 Kapr Johnik
2001-09-25 22:47 ` David Weinehall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010926004755.A968@khan.acc.umu.se \
--to=tao@acc.umu.se \
--cc=kapr.johnik@seznam.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox