From: Kapr Johnik <kapr.johnik@seznam.cz>
To: linux-kernel@vger.kernel.org
Subject: [PATCH-2.2.19] bug in cs89x0
Date: Tue, 25 Sep 2001 10:11:42 +0200 [thread overview]
Message-ID: <3BB03C3E.3080906@seznam.cz> (raw)
Hi to all.
I think I've found bug in the cs89x0 network driver in 2.2.19, which we
are using in an embedded network router. The driver does not use
skb_put(), instead it writes directly to skb->len and leaves skb->tail
incorrect. Patch follows.
diff -u -r linux-2.2.19/drivers/net/cs89x0.c linux/drivers/net/cs89x0.c
--- linux-2.2.19/drivers/net/cs89x0.c Sun Mar 25 18:37:34 2001
+++ linux/drivers/net/cs89x0.c Tue Sep 25 09:39:35 2001
@@ -904,7 +904,7 @@
lp->stats.rx_dropped++;
return;
}
- skb->len = length;
+ skb_put(skb, length);
skb->dev = dev;
insw(ioaddr + RX_FRAME_PORT, skb->data, length >> 1);
next reply other threads:[~2001-09-25 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-25 8:11 Kapr Johnik [this message]
2001-09-25 22:47 ` [PATCH-2.2.19] bug in cs89x0 David Weinehall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BB03C3E.3080906@seznam.cz \
--to=kapr.johnik@seznam.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox