[PATCH] SB driver, kernel 2.4.10

[PATCH] SB driver, kernel 2.4.10

[Jerome Cornet]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

    Hi there,

The PnP initialisation of my brand old SB AWE64 PnP was not supported by the 
current (2.4.10) kernel driver (I could initialise it by using isapnptools, 
but not directly by the pnp driver).

I patched sb_card.c so that the device ID of my board is known by the SB 
driver, thus allowing the isapnp initialisation by the driver directly.

I tested it on my computer, and I don't expect the patch to break anything 
(it's a no brainer fix)

Maybe you can consider applying it to the next release ?

Thank you,
 /Jerome

PS: please CC: me for the replies, I'm not subscribed to linux-kernel

[-- Attachment #2: The readme file --]
[-- Type: text/plain, Size: 80 bytes --]

Jerome Cornet <jcornet@free.fr>: Add a new flavor of AWE64 PnP to the sb driver

[-- Attachment #3: the patch itself --]
[-- Type: text/x-diff, Size: 744 bytes --]

--- kernel-source-2.4.10/drivers/sound/sb_card.c	Tue Sep 18 17:10:43 2001
+++ linux/drivers/sound/sb_card.c	Tue Oct  2 17:35:06 2001
@@ -53,6 +53,9 @@
  *
  * 28-10-2000 Added pnplegacy support
  * 	Daniel Church <dchurch@mbhs.edu>
+ *
+ * 01-10-2001 Added a new flavor of Creative SB AWE64 PnP (CTL00E9).
+ *      Jerome Cornet <jcornet@free.fr>
  */
 
 #include <linux/config.h>
@@ -435,6 +438,11 @@
 		0,1,1,-1},
 	{"Sound Blaster AWE 64",
 		ISAPNP_VENDOR('C','T','L'), ISAPNP_DEVICE(0x00E4), 
+		ISAPNP_VENDOR('C','T','L'), ISAPNP_FUNCTION(0x0045),
+		0,0,0,0,
+		0,1,1,-1},
+	{"Sound Blaster AWE 64",
+		ISAPNP_VENDOR('C','T','L'), ISAPNP_DEVICE(0x00E9), 
 		ISAPNP_VENDOR('C','T','L'), ISAPNP_FUNCTION(0x0045),
 		0,0,0,0,
 		0,1,1,-1},

Re: [PATCH] SB driver, kernel 2.4.10

[Andrey Panin]

[-- Attachment #1.1: Type: text/plain, Size: 942 bytes --]

On Tue, Oct 02, 2001 at 05:52:05PM -0400, Jerome Cornet wrote:

>     Hi there,
> 
> The PnP initialisation of my brand old SB AWE64 PnP was not supported by the 
> current (2.4.10) kernel driver (I could initialise it by using isapnptools, 
> but not directly by the pnp driver).
> 
> I patched sb_card.c so that the device ID of my board is known by the SB 
> driver, thus allowing the isapnp initialisation by the driver directly.
> 
> I tested it on my computer, and I don't expect the patch to break anything 
> (it's a no brainer fix)
> 
> Maybe you can consider applying it to the next release ?
> 
> Thank you,
>  /Jerome
> 
> PS: please CC: me for the replies, I'm not subscribed to linux-kernel

Device ID should be added to id_table[] also. New patch attached.

-- 
Andrey Panin            | Embedded systems software engineer
pazke@orbita1.ru        | PGP key: http://www.orbita1.ru/~pazke/AndreyPanin.asc

[-- Attachment #1.2: linux-2.4.10-awe64-full.patch --]
[-- Type: text/plain, Size: 1256 bytes --]

diff -urN linux.vanilla/drivers/sound/sb_card.c linux/drivers/sound/sb_card.c
--- linux.vanilla/drivers/sound/sb_card.c	Wed Oct  3 10:05:56 2001
+++ linux/drivers/sound/sb_card.c	Wed Oct  3 10:11:40 2001
@@ -53,6 +53,9 @@
  *
  * 28-10-2000 Added pnplegacy support
  * 	Daniel Church <dchurch@mbhs.edu>
+ *
+ * 01-10-2001 Added a new flavor of Creative SB AWE64 PnP (CTL00E9).
+ *      Jerome Cornet <jcornet@free.fr>
  */
 
 #include <linux/config.h>
@@ -423,6 +426,11 @@
 		ISAPNP_VENDOR('C','T','L'), ISAPNP_FUNCTION(0x0045),
 		0,0,0,0,
 		0,1,1,-1},
+	{"Sound Blaster AWE 64",
+		ISAPNP_VENDOR('C','T','L'), ISAPNP_DEVICE(0x00E9), 
+		ISAPNP_VENDOR('C','T','L'), ISAPNP_FUNCTION(0x0045),
+		0,0,0,0,
+		0,1,1,-1},
 	{"ESS 1688",
 		ISAPNP_VENDOR('E','S','S'), ISAPNP_DEVICE(0x0968), 
 		ISAPNP_VENDOR('E','S','S'), ISAPNP_FUNCTION(0x0968),
@@ -604,6 +612,9 @@
 		ISAPNP_VENDOR('C','T','L'), ISAPNP_FUNCTION(0x0045), 0 },
 
 	{	ISAPNP_VENDOR('C','T','L'), ISAPNP_DEVICE(0x00E4), 
+		ISAPNP_VENDOR('C','T','L'), ISAPNP_FUNCTION(0x0045), 0 },
+
+	{	ISAPNP_VENDOR('C','T','L'), ISAPNP_DEVICE(0x00E9),
 		ISAPNP_VENDOR('C','T','L'), ISAPNP_FUNCTION(0x0045), 0 },
 
 	{	ISAPNP_VENDOR('E','S','S'), ISAPNP_DEVICE(0x0968), 

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]