* Re: 2.4.17-pre2: unclean cleanup in i2ellis.c
2001-12-06 17:54 2.4.17-pre2: unclean cleanup in i2ellis.c René Scharfe
@ 2001-12-06 16:36 ` Marcelo Tosatti
0 siblings, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2001-12-06 16:36 UTC (permalink / raw)
To: René Scharfe
Cc: Linux Kernel Mailing List, Michael H.Warfield, David S. Miller
Could you please send me a patch to undo that change ?
Thanks
On Thu, 6 Dec 2001, René Scharfe wrote:
> Hi,
>
> in 2.4.17-pre2 the definition of iiEllisCleanup() in
> drivers/char/i2ellis.c got #if 0'd because it's unused. Problem is,
> drivers/char/ip2main.c still calls this function in line 559.
>
> René
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* 2.4.17-pre2: unclean cleanup in i2ellis.c
@ 2001-12-06 17:54 René Scharfe
2001-12-06 16:36 ` Marcelo Tosatti
0 siblings, 1 reply; 3+ messages in thread
From: René Scharfe @ 2001-12-06 17:54 UTC (permalink / raw)
To: Marcelo Tosatti, Linux Kernel Mailing List; +Cc: Michael H. Warfield
Hi,
in 2.4.17-pre2 the definition of iiEllisCleanup() in
drivers/char/i2ellis.c got #if 0'd because it's unused. Problem is,
drivers/char/ip2main.c still calls this function in line 559.
René
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.4.17-pre2: unclean cleanup in i2ellis.c
@ 2001-12-06 19:09 René Scharfe
0 siblings, 0 replies; 3+ messages in thread
From: René Scharfe @ 2001-12-06 19:09 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Linux Kernel Mailing List
> Could you please send me a patch to undo that change ?
Sure.
--- linux-2.4.17-pre2/drivers/char/ip2/i2ellis.c Thu Dec 6 19:38:02 2001
+++ linux-2.4.17-pre1/drivers/char/ip2/i2ellis.c Wed Oct 24 21:05:18 2001
@@ -102,7 +102,6 @@
// This routine performs any required cleanup of the iiEllis subsystem.
//
//******************************************************************************
-#if 0 /* Unused */
static void
iiEllisCleanup(void)
{
@@ -110,7 +109,6 @@
kfree ( pDelayTimer );
}
}
-#endif
//******************************************************************************
// Function: iiSetAddress(pB, address, delay)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-12-06 19:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-12-06 17:54 2.4.17-pre2: unclean cleanup in i2ellis.c René Scharfe
2001-12-06 16:36 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2001-12-06 19:09 René Scharfe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox