public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thibaut Laurent <thibaut@celestix.com>
To: Christer Weinigel <wingel@acolyte.hack.org>
Cc: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NatSemi SCx200 Support
Date: Mon, 4 Mar 2002 07:37:29 +0800	[thread overview]
Message-ID: <20020304073729.59946087.thibaut@celestix.com> (raw)
In-Reply-To: <20020302160110.11DE1F5B@acolyte.hack.org>
In-Reply-To: <Pine.LNX.4.21.0202281244330.2117-100000@freak.distro.conectiva> <20020302160110.11DE1F5B@acolyte.hack.org>

On Sat,  2 Mar 2002 17:01:10 +0100 (CET)
Christer Weinigel <wingel@acolyte.hack.org> wrote:

 | Marcelo Tosatti <marcelo@conectiva.com.br> wrote:
 | > Your patch does not apply cleanly to my tree, probably due to some
 | > already applied patches.
 | > 
 | > Please regenerate your patch against -pre2 as soon as its released.
 | 
 | This is an updated patch for SCx200 support.  This patch is against
 | linux-2.4.19-pre2 and adds support for some SCx200 specific features
 | such as the GPIO pins, the watchdog and flash mapping via the DOCCS
 | pin.  Compared to the earlier patch, I've cleaned up a few more
 | things, and have also added a driver for the ACCESS.bus found in the
 | SCx200 CPUs.

There's a typo in drivers/i2c/Config.in.
CONFIG_SCx200_I2C is defined but CONFIG_I2C_SCx200 is tested...

+      dep_tristate '  NatSemi SCx200 I2C using GPIO pins' CONFIG_SCx200_I2C $CONFIG_ARCH_SCx200 $CONFIG_I2C_ALGOBIT
+      if [ "$CONFIG_I2C_SCx200" != "n" ]; then
              ^^^^^^^^^^^^^^^^^
     this should be CONFIG_SCx200_I2C


Regards,

Thibaut


  reply	other threads:[~2002-03-04  0:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-26  1:52 [PATCH] NatSemi SCx200 Support Christer Weinigel
2002-02-28 15:45 ` Marcelo Tosatti
2002-03-02 16:01   ` Christer Weinigel
2002-03-03 23:37     ` Thibaut Laurent [this message]
2002-03-04  1:26       ` Christer Weinigel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020304073729.59946087.thibaut@celestix.com \
    --to=thibaut@celestix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=wingel@acolyte.hack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox