public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* irqbalance+O(1)-sched
@ 2002-05-07 15:03 J.A. Magallon
  2002-05-07 15:08 ` irqbalance+O(1)-sched William Lee Irwin III
  2002-05-07 15:13 ` irqbalance+O(1)-sched William Lee Irwin III
  0 siblings, 2 replies; 3+ messages in thread
From: J.A. Magallon @ 2002-05-07 15:03 UTC (permalink / raw)
  To: Lista Linux-Kernel; +Cc: Robert Love, Ingo Molnar

Hi all...

I am trying to mix the irqbalance patch on top of the O1-scheduler
to use it on a dual P4 box.

Everything mix easy but this piece of code in irqbalance:

int idle_cpu(int cpu)
{
   return cpu_curr(cpu) == idle_task(cpu);
}

2.4.18 defines it as 

sched.c:#define idle_task(cpu) (init_tasks[cpu_number_map(cpu)])
...
sched.c:#define idle_task(cpu) (&init_task)

but O1 kills it.

Any syggestion on hwo to implement idle_cpu() on top of O1 ?

Thanks

-- 
J.A. Magallon                           #  Let the source be with you...        
mailto:jamagallon@able.es
Mandrake Linux release 8.3 (Cooker) for i586
Linux werewolf 2.4.19-pre8-jam1 #1 SMP mar may 7 01:51:45 CEST 2002 i686

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: irqbalance+O(1)-sched
  2002-05-07 15:03 irqbalance+O(1)-sched J.A. Magallon
@ 2002-05-07 15:08 ` William Lee Irwin III
  2002-05-07 15:13 ` irqbalance+O(1)-sched William Lee Irwin III
  1 sibling, 0 replies; 3+ messages in thread
From: William Lee Irwin III @ 2002-05-07 15:08 UTC (permalink / raw)
  To: J.A. Magallon; +Cc: Lista Linux-Kernel, Robert Love, Ingo Molnar

On Tue, May 07, 2002 at 05:03:57PM +0200, J.A. Magallon wrote:
> Everything mix easy but this piece of code in irqbalance:
> int idle_cpu(int cpu)
> {
>    return cpu_curr(cpu) == idle_task(cpu);
> }
> 2.4.18 defines it as 
> sched.c:#define idle_task(cpu) (init_tasks[cpu_number_map(cpu)])
> ...
> sched.c:#define idle_task(cpu) (&init_task)
> but O1 kills it.
> Any syggestion on hwo to implement idle_cpu() on top of O1 ?

int idle_cpu(int cpu)
{
	return cpu_curr(cpu) == cpu_rq(cpu)->idle;
}

Cheers,
Bill

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: irqbalance+O(1)-sched
  2002-05-07 15:03 irqbalance+O(1)-sched J.A. Magallon
  2002-05-07 15:08 ` irqbalance+O(1)-sched William Lee Irwin III
@ 2002-05-07 15:13 ` William Lee Irwin III
  1 sibling, 0 replies; 3+ messages in thread
From: William Lee Irwin III @ 2002-05-07 15:13 UTC (permalink / raw)
  To: J.A. Magallon; +Cc: Lista Linux-Kernel, Robert Love, Ingo Molnar

On Tue, May 07, 2002 at 05:03:57PM +0200, J.A. Magallon wrote:
> I am trying to mix the irqbalance patch on top of the O1-scheduler
> to use it on a dual P4 box.
> Everything mix easy but this piece of code in irqbalance:
> int idle_cpu(int cpu)
> {
>    return cpu_curr(cpu) == idle_task(cpu);
> }
> 2.4.18 defines it as 
> sched.c:#define idle_task(cpu) (init_tasks[cpu_number_map(cpu)])
> ...
> sched.c:#define idle_task(cpu) (&init_task)
> but O1 kills it.
> Any syggestion on hwo to implement idle_cpu() on top of O1 ?

Another quick one might be

#define idle_task(cpu) (cpu_rq(cpu)->idle)

which leaves idle_cpu() unchanged.

Cheers,
Bill

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-05-07 15:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-05-07 15:03 irqbalance+O(1)-sched J.A. Magallon
2002-05-07 15:08 ` irqbalance+O(1)-sched William Lee Irwin III
2002-05-07 15:13 ` irqbalance+O(1)-sched William Lee Irwin III

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox