From: Greg KH <greg@kroah.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.15 laziness in export-objs
Date: Thu, 9 May 2002 19:42:42 -0700 [thread overview]
Message-ID: <20020510024242.GA20468@kroah.com> (raw)
In-Reply-To: <25744.1020998571@kao2.melbourne.sgi.com>
On Fri, May 10, 2002 at 12:42:51PM +1000, Keith Owens wrote:
> 2.5.15 has four Makefiles where all objects are marked as exporting
> symbols. This is lazy coding and causes spurious rebuilds. Please
> specify only those objects that really export symbols.
>
> Also the export list is independent of whether an object is selected or
> not. That is, export-objs is unconditional.
Does this patch fix up arch/i386/pci/Makefile and drivers/pci/Makefile
properly?
thanks,
greg k-h
diff -Nru a/arch/i386/pci/Makefile b/arch/i386/pci/Makefile
--- a/arch/i386/pci/Makefile Thu May 9 20:50:36 2002
+++ b/arch/i386/pci/Makefile Thu May 9 20:50:36 2002
@@ -24,6 +24,4 @@
obj-y += irq.o common.o
endif # CONFIG_VISWS
-export-objs += $(obj-y)
-
include $(TOPDIR)/Rules.make
diff -Nru a/drivers/pci/Makefile b/drivers/pci/Makefile
--- a/drivers/pci/Makefile Thu May 9 20:50:36 2002
+++ b/drivers/pci/Makefile Thu May 9 20:50:36 2002
@@ -37,7 +37,8 @@
obj-y += syscall.o
endif
-export-objs := $(obj-y)
+export-objs := access.o hotplug.o pci.o pci-driver.o \
+ pool.o probe.o proc.o search.o
include $(TOPDIR)/Rules.make
next prev parent reply other threads:[~2002-05-10 3:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-10 2:42 2.5.15 laziness in export-objs Keith Owens
2002-05-10 2:42 ` Greg KH [this message]
2002-05-10 4:03 ` Keith Owens
2002-05-10 16:25 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020510024242.GA20468@kroah.com \
--to=greg@kroah.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox