Re: 2.5.15 laziness in export-objs

Re: 2.5.15 laziness in export-objs

[Greg KH]

On Fri, May 10, 2002 at 12:42:51PM +1000, Keith Owens wrote:
> 2.5.15 has four Makefiles where all objects are marked as exporting
> symbols.  This is lazy coding and causes spurious rebuilds.  Please
> specify only those objects that really export symbols.
> 
> Also the export list is independent of whether an object is selected or
> not.  That is, export-objs is unconditional.

Does this patch fix up arch/i386/pci/Makefile and drivers/pci/Makefile
properly?

thanks,

greg k-h


diff -Nru a/arch/i386/pci/Makefile b/arch/i386/pci/Makefile
--- a/arch/i386/pci/Makefile	Thu May  9 20:50:36 2002
+++ b/arch/i386/pci/Makefile	Thu May  9 20:50:36 2002
@@ -24,6 +24,4 @@
 obj-y		+= irq.o common.o
 endif		# CONFIG_VISWS
 
-export-objs     +=      $(obj-y)
-
 include $(TOPDIR)/Rules.make
diff -Nru a/drivers/pci/Makefile b/drivers/pci/Makefile
--- a/drivers/pci/Makefile	Thu May  9 20:50:36 2002
+++ b/drivers/pci/Makefile	Thu May  9 20:50:36 2002
@@ -37,7 +37,8 @@
 obj-y += syscall.o
 endif
 
-export-objs := $(obj-y)
+export-objs	:= access.o hotplug.o pci.o pci-driver.o \
+		pool.o probe.o proc.o search.o
 
 include $(TOPDIR)/Rules.make
 

2.5.15 laziness in export-objs

[Keith Owens]

2.5.15 has four Makefiles where all objects are marked as exporting
symbols.  This is lazy coding and causes spurious rebuilds.  Please
specify only those objects that really export symbols.

Also the export list is independent of whether an object is selected or
not.  That is, export-objs is unconditional.

fs/nls/Makefile:export-objs = $(obj-y)
arch/i386/pci/Makefile:export-objs     +=      $(obj-y)
drivers/base/Makefile:export-objs     := $(obj-y)
drivers/pci/Makefile:export-objs := $(obj-y)

cd directory
echo $(fgrep -l EXPORT_SYMBOL *.c | tr '\n' ' ' | sed -e '{s/^/export-objs := /; s/\.c/.o/g; }')
will get the correct list.  arch/i386/pci/Makefile exports nothing at all.

Re: 2.5.15 laziness in export-objs

[Keith Owens]

On Thu, 9 May 2002 19:42:42 -0700, 
Greg KH <greg@kroah.com> wrote:
>Does this patch fix up arch/i386/pci/Makefile and drivers/pci/Makefile
>properly?

Looks good.

Re: 2.5.15 laziness in export-objs

[Patrick Mochel]

On Fri, 10 May 2002, Keith Owens wrote:

> 2.5.15 has four Makefiles where all objects are marked as exporting
> symbols.  This is lazy coding and causes spurious rebuilds.  Please
> specify only those objects that really export symbols.
> 
> Also the export list is independent of whether an object is selected or
> not.  That is, export-objs is unconditional.
> 
> fs/nls/Makefile:export-objs = $(obj-y)
> arch/i386/pci/Makefile:export-objs     +=      $(obj-y)
> drivers/base/Makefile:export-objs     := $(obj-y)
> drivers/pci/Makefile:export-objs := $(obj-y)

Here is the patch for drivers/base.

	-pat

===== drivers/base/Makefile 1.3 vs edited =====
--- 1.3/drivers/base/Makefile	Tue Mar 26 14:26:45 2002
+++ edited/drivers/base/Makefile	Fri May 10 09:24:33 2002
@@ -2,6 +2,6 @@
 
 obj-y		:= core.o sys.o interface.o fs.o power.o
 
-export-objs	:= $(obj-y)
+export-objs	:= core.o fs.o power.o sys.o
 
 include $(TOPDIR)/Rules.make