From: "David S. Miller" <davem@redhat.com>
To: jasonp@boo.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] page coloring for 2.4.18 kernel
Date: Tue, 04 Jun 2002 06:16:40 -0700 (PDT) [thread overview]
Message-ID: <20020604.061640.118624496.davem@redhat.com> (raw)
In-Reply-To: <3.0.6.32.20020407110100.007c2b70@boo.net>
From: Jason Papadopoulos <jasonp@boo.net>
Date: Sun, 07 Apr 2002 11:01:00 -0400
Hello. This is a re-diff of the 2.4.17 patch I posted
previously.
www.boo.net/~jasonp/page_color-2.2.20-20020108.patch
www.boo.net/~jasonp/page_color-2.4.17-20020113.patch
www.boo.net/~jasonp/page_color-2.4.18-20020323.patch
I'm not subscribed to LKML, so please cc responses
to this email address.
Hi Jason. I noticed that your code assumes zones begin on well
aligned physical addresses. This is not true.
For example, in page_color_start you use the raw
(page - zone->zone_mem_map) index as the color. This
is wrong, what if the zone starts at page 1? In such
a case all of your colors will be computed incorrectly
and pages with different colors in different zones can actually be of
the same color.
next prev parent reply other threads:[~2002-06-04 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-07 15:01 [PATCH] page coloring for 2.4.18 kernel Jason Papadopoulos
2002-06-04 13:16 ` David S. Miller [this message]
2002-06-04 16:59 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2002-04-09 1:09 Dieter Nützel
2002-04-23 21:51 Dieter Nützel
2002-04-23 21:53 ` Robert Love
2002-04-24 2:48 ` Jason Papadopoulos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020604.061640.118624496.davem@redhat.com \
--to=davem@redhat.com \
--cc=jasonp@boo.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox