From: Rusty Russell <rusty@rustcorp.com.au>
To: torvalds@transmeta.com (Linus Torvalds)
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.5.23 cpu_online_map undeclared
Date: Fri, 21 Jun 2002 08:59:35 +1000 [thread overview]
Message-ID: <20020621085935.7650d28a.rusty@rustcorp.com.au> (raw)
In-Reply-To: <aep588$21j$1@penguin.transmeta.com>
On Wed, 19 Jun 2002 05:36:08 +0000 (UTC)
torvalds@transmeta.com (Linus Torvalds) wrote:
> Actually, it _should_ be declared, it's just that on UP it should be
> defined to the constant 1.
>
> Somehow that #define got dropped by the hotplug-CPU stuff.
Actually, was deliberate. Not exposing the mask when almost everyone
just wants to know "are any of these cpus online" was a preemptive strike
against NR_CPUS > BITS_PER_LONG (I wouldn't have bothered but I was so
close anyway).
My mistake was not noticing that x86 SMP was still exposing it and that
scheduler changes since my original patch were using it. Fixed with
cpu_online_mask(res, mask) in prior patch.
Apologies, and hope that clarifies,
Rusty.
--
there are those who do and those who hang on and you don't see too
many doers quoting their contemporaries. -- Larry McVoy
prev parent reply other threads:[~2002-06-20 22:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-19 3:14 Linux 2.5.23 cpu_online_map undeclared John Weber
2002-06-19 5:36 ` Linus Torvalds
2002-06-19 6:38 ` Ingo Molnar
2002-06-20 22:59 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020621085935.7650d28a.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox