From: torvalds@transmeta.com (Linus Torvalds)
To: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.5.23 cpu_online_map undeclared
Date: Wed, 19 Jun 2002 05:36:08 +0000 (UTC) [thread overview]
Message-ID: <aep588$21j$1@penguin.transmeta.com> (raw)
In-Reply-To: 3D0FF715.7040601@linuxhq.com
In article <3D0FF715.7040601@linuxhq.com>,
John Weber <john.weber@linuxhq.com> wrote:
>I am running on a UP system, so I don't believe that cpu_online_map
>should be declared. Any suggestions?
Actually, it _should_ be declared, it's just that on UP it should be
defined to the constant 1.
Somehow that #define got dropped by the hotplug-CPU stuff.
To fix, just add a
#define cpu_online_map 1
to the non-SMP parts of include/linus/smp.h. The patch looks something
like the appended (totally untested) thing.
Does that make UP happier?
Linus
--- 1.8/include/linux/smp.h Mon Jun 17 23:25:22 2002
+++ edited/include/linux/smp.h Tue Jun 18 22:30:47 2002
@@ -86,6 +86,7 @@
#define smp_call_function(func,info,retry,wait) ({ 0; })
static inline void smp_send_reschedule(int cpu) { }
static inline void smp_send_reschedule_all(void) { }
+#define cpu_online_map 1
#define cpu_online(cpu) 1
#define num_online_cpus() 1
#define __per_cpu_data
next prev parent reply other threads:[~2002-06-19 5:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-19 3:14 Linux 2.5.23 cpu_online_map undeclared John Weber
2002-06-19 5:36 ` Linus Torvalds [this message]
2002-06-19 6:38 ` Ingo Molnar
2002-06-20 22:59 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aep588$21j$1@penguin.transmeta.com' \
--to=torvalds@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox