The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Andre Hedrick <andre@linux-ide.org>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
	Anton Altaparmakov <aia21@cantab.net>,
	linux-kernel@vger.kernel.org, sullivan@austin.ibm.com
Subject: Re: [BUG-2.5.24-BK] DriverFS panics on boot!
Date: Fri, 5 Jul 2002 08:34:01 +0200	[thread overview]
Message-ID: <20020705063401.GI1007@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.10.10207041900080.19028-100000@master.linux-ide.org>

On Thu, Jul 04 2002, Andre Hedrick wrote:
> 	1) 8K writes and 64K (or larger) reads.

I've heard this before, but noone seems to have tested it yet. You know,
this is a couple of lines of change in ll_rw_blk.c and blkdev.h to
support this. Any reason you haven't done that, benched, and submitted
something to that effect? I'll even walk you through the 2.5 changes
needed to do this:

blkdev.h:
	unsigned short max_sectors;

change to

	unsigned short max_sectors[2];

ll_rw_blk.c:
	ll_back_merge_fn()
	if (req->nr_sectors + bio_sectors(bio) > q->max_sectors) {

change to

	if (req->nr_sectors + bio_sectors(bio) > q->max_sectors[rq_data_dir[req]) {

Ditto for ll_front_merge_fn() and ll_merge_requests_fn(). The line in
attempt_merge() can be killed.

	generic_make_request()
	BUG_ON(bio_sectors(bio) > q->max_sectors);

change to

	BUG_ON(bio_sectors(bio) > q->max_sectors[bio_data_dir(bio)];

And do the trivial thing to blk_queue_max_sectors() as well. Now all you
need to do is change ide-probe.c to set the values you want.

> 	2) ONE maybe TWO passes on elevator operations.

Explain.

> Since this is falling on deaf ears in general, oh well.

How so?

-- 
Jens Axboe


  reply	other threads:[~2002-07-05  6:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-04 15:41 [BUG-2.5.24-BK] DriverFS panics on boot! James Bottomley
2002-07-04 15:55 ` Anton Altaparmakov
2002-07-04 22:20 ` Andre Hedrick
2002-07-04 22:59   ` James Bottomley
2002-07-05  2:15     ` Andre Hedrick
2002-07-05  6:34       ` Jens Axboe [this message]
2002-07-05  6:51         ` Andre Hedrick
2002-07-05  7:38           ` Jens Axboe
2002-07-05 22:43             ` Andre Hedrick
  -- strict thread matches above, loose matches on Subject: below --
2002-07-04 11:28 Anton Altaparmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020705063401.GI1007@suse.de \
    --to=axboe@suse.de \
    --cc=James.Bottomley@steeleye.com \
    --cc=aia21@cantab.net \
    --cc=andre@linux-ide.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sullivan@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox