From: Ravikiran G Thirumalai <kiran@in.ibm.com>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Patch 2.5.25: Ensure xtime_lock and timerlist_lock are on difft cachelines
Date: Thu, 25 Jul 2002 20:45:12 +0530 [thread overview]
Message-ID: <20020725204512.E3594@in.ibm.com> (raw)
I've noticed that xtime_lock and timerlist_lock ends up on the same
cacheline all the time (atleaset on x86). Not a good thing for
loads with high xxx_timer and do_gettimeofday counts I guess (networking etc).
Here's a 2.5.25 objdump:
c0302780 g O .data 00000004 time_freq
c0302784 g O .data 00000004 timerlist_lock
c0302788 g O .data 00000004 tqueue_lock
c030278c g O .data 00000004 xtime_lock
c0302790 l O .data 00000004 count.3
c0302794 l O .data 00000004 uidhash_lock
c0302798 g O .data 00000018 root_user
Here's a trivial 2.5.28 based fix.
-Kiran
diff -ruN -X dontdiff linux-2.5.28/kernel/timer.c align_locks/kernel/timer.c
--- linux-2.5.28/kernel/timer.c Thu Jul 25 02:33:23 2002
+++ align_locks/kernel/timer.c Thu Jul 25 18:17:46 2002
@@ -169,7 +169,7 @@
}
/* Initialize both explicitly - let's try to have them in the same cache line */
-spinlock_t timerlist_lock = SPIN_LOCK_UNLOCKED;
+spinlock_t timerlist_lock ____cacheline_aligned_in_smp = SPIN_LOCK_UNLOCKED;
#ifdef CONFIG_SMP
volatile struct timer_list * volatile running_timer;
@@ -327,7 +327,7 @@
spin_unlock_irq(&timerlist_lock);
}
-spinlock_t tqueue_lock = SPIN_LOCK_UNLOCKED;
+spinlock_t tqueue_lock __cacheline_aligned_in_smp = SPIN_LOCK_UNLOCKED;
void tqueue_bh(void)
{
@@ -633,7 +633,7 @@
* This read-write spinlock protects us from races in SMP while
* playing with xtime and avenrun.
*/
-rwlock_t xtime_lock = RW_LOCK_UNLOCKED;
+rwlock_t xtime_lock __cacheline_aligned_in_smp = RW_LOCK_UNLOCKED;
unsigned long last_time_offset;
static inline void update_times(void)
next reply other threads:[~2002-07-25 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-25 15:15 Ravikiran G Thirumalai [this message]
2002-07-26 6:24 ` Patch 2.5.25: Ensure xtime_lock and timerlist_lock are on difft cachelines Rusty Russell
2002-07-26 7:26 ` Kiran
2002-07-26 7:56 ` Rusty Russell
2002-07-26 9:23 ` Kiran
2002-07-27 4:17 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020725204512.E3594@in.ibm.com \
--to=kiran@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox