From: William Lee Irwin III <wli@holomorphy.com>
To: Andrew Morton <akpm@zip.com.au>
Cc: Linus Torvalds <torvalds@transmeta.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 13/21] deferred and batched addition of faulted-in pages to the LRU
Date: Mon, 12 Aug 2002 06:29:38 -0700 [thread overview]
Message-ID: <20020812132938.GL15685@holomorphy.com> (raw)
In-Reply-To: <3D5614B2.EFD25A8D@zip.com.au>
On Sun, Aug 11, 2002 at 12:39:30AM -0700, Andrew Morton wrote:
> pagevec_init(&pvec);
>
> + lru_add_drain();
> spin_lock_irq(&_pagemap_lru_lock);
> while (max_scan > 0 && nr_pages > 0) {
> struct page *page;
> @@ -380,6 +381,7 @@ static /* inline */ void refill_inactive
> struct page *page;
> struct pagevec pvec;
>
> + lru_add_drain();
> spin_lock_irq(&_pagemap_lru_lock);
> while (nr_pages && !list_empty(&active_list)) {
> page = list_entry(active_list.prev, struct page, lru);
Looks to me like it could be advantageous to perform the draining while
already under the lock. But the gains from this and the other changes are
already so vast it seems like it could have at most a minor effect.
Cheers,
Bill
next prev parent reply other threads:[~2002-08-12 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-11 7:39 [patch 13/21] deferred and batched addition of faulted-in pages to the LRU Andrew Morton
2002-08-12 13:29 ` William Lee Irwin III [this message]
[not found] <3D5614B2.EFD25A8D@zip.com.au.suse.lists.linux.kernel>
2002-08-11 9:23 ` Andi Kleen
2002-08-11 9:48 ` Andrew Morton
2002-08-11 9:47 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020812132938.GL15685@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox