From: Andrew Morton <akpm@zip.com.au>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 13/21] deferred and batched addition of faulted-in pages to the LRU
Date: Sun, 11 Aug 2002 02:48:23 -0700 [thread overview]
Message-ID: <3D5632E7.F801228F@zip.com.au> (raw)
In-Reply-To: p73wuqxiwar.fsf@oldwotan.suse.de
Andi Kleen wrote:
>
> Andrew Morton <akpm@zip.com.au> writes:
> > */
> > -void lru_cache_add(struct page * page)
> > +static struct pagevec lru_add_pvecs[NR_CPUS];
> > +
> > +void lru_cache_add(struct page *page)
> > +{
> > + struct pagevec *pvec = &lru_add_pvecs[get_cpu()];
>
> This should probably use the linux/percpu.h macros.
> This way it could be more efficient on some architectures and also avoid
> potential false sharing.
Yes, I need to do a sweep sometime and convert some things like
that. Preferably after the hot-remove APIs are there. Or is
that not planned?
next prev parent reply other threads:[~2002-08-11 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3D5614B2.EFD25A8D@zip.com.au.suse.lists.linux.kernel>
2002-08-11 9:23 ` [patch 13/21] deferred and batched addition of faulted-in pages to the LRU Andi Kleen
2002-08-11 9:48 ` Andrew Morton [this message]
2002-08-11 9:47 ` Andi Kleen
2002-08-11 7:39 Andrew Morton
2002-08-12 13:29 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D5632E7.F801228F@zip.com.au \
--to=akpm@zip.com.au \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox