The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Julien BLACHE <jb@jblache.org>
Cc: Brad Hards <bhards@bigpond.net.au>, Adrian Bunk <bunk@fs.tum.de>,
	linux-kernel@vger.kernel.org, rlievin@free.fr
Subject: Re: [2.5 patch] tiglusb.c must include version.h
Date: Mon, 12 Aug 2002 10:30:30 -0700	[thread overview]
Message-ID: <20020812173030.GA15652@kroah.com> (raw)
In-Reply-To: <87znvsmqfx.fsf@frigate.technologeek.org>

On Mon, Aug 12, 2002 at 10:28:18AM +0200, Julien BLACHE wrote:
> Brad Hards <bhards@bigpond.net.au> wrote:
> 
> Hi,
> 
> >> line 44 is:
> >>   #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
> >>
> >>
> >> The fix is simple:
> > <snip>
> >> +#include <linux/version.h>
> >
> > Wouldn't it be cleaner to just remove this case? It is in 2.5, after all.

I agree.

> But if this should become a hassle for anybody, I'll remove this case
> ASAP.

Don't worry about it, I just made the change in my tree, and will send
the change to Linus later today.

thanks,

greg k-h

      reply	other threads:[~2002-08-12 17:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-11 12:20 [2.5 patch] tiglusb.c must include version.h Adrian Bunk
2002-08-12  0:12 ` Brad Hards
2002-08-12  8:28   ` Julien BLACHE
2002-08-12 17:30     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020812173030.GA15652@kroah.com \
    --to=greg@kroah.com \
    --cc=bhards@bigpond.net.au \
    --cc=bunk@fs.tum.de \
    --cc=jb@jblache.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rlievin@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox