From: Julien BLACHE <jb@jblache.org>
To: Brad Hards <bhards@bigpond.net.au>
Cc: Adrian Bunk <bunk@fs.tum.de>, <greg@kroah.com>,
linux-kernel@vger.kernel.org, rlievin@free.fr
Subject: Re: [2.5 patch] tiglusb.c must include version.h
Date: Mon, 12 Aug 2002 10:28:18 +0200 [thread overview]
Message-ID: <87znvsmqfx.fsf@frigate.technologeek.org> (raw)
In-Reply-To: <200208121012.59099.bhards@bigpond.net.au> (Brad Hards's message of "Mon, 12 Aug 2002 10:12:47 +1000")
Brad Hards <bhards@bigpond.net.au> wrote:
Hi,
>> line 44 is:
>> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
>>
>>
>> The fix is simple:
> <snip>
>> +#include <linux/version.h>
>
> Wouldn't it be cleaner to just remove this case? It is in 2.5, after all.
We use this case so we don't have to maintain 2 /slightly/ different
versions of the source, as we're distributing this module outside of
the kernel tree for use with kernel 2.4.x.
Moreover I asked Greg to push this module into the 2.4 tree if
possible, so as long as there aren't major changes in the 2.5 code
I'd really like to keep the same source for 2.4 and 2.5.
But if this should become a hassle for anybody, I'll remove this case
ASAP.
JB.
--
Julien BLACHE <http://www.jblache.org>
<jb@jblache.org>
next prev parent reply other threads:[~2002-08-12 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-11 12:20 [2.5 patch] tiglusb.c must include version.h Adrian Bunk
2002-08-12 0:12 ` Brad Hards
2002-08-12 8:28 ` Julien BLACHE [this message]
2002-08-12 17:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87znvsmqfx.fsf@frigate.technologeek.org \
--to=jb@jblache.org \
--cc=bhards@bigpond.net.au \
--cc=bunk@fs.tum.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rlievin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox