From: Muli Ben-Yehuda <mulix@actcom.co.il>
To: Andrew Morton <akpm@zip.com.au>
Cc: "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: [patch] __func__ -> __FUNCTION__
Date: Tue, 13 Aug 2002 10:59:44 +0300 [thread overview]
Message-ID: <20020813075944.GA2192@alhambra.actcom.co.il> (raw)
In-Reply-To: <3D58BF90.56C75C66@zip.com.au>
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
On Tue, Aug 13, 2002 at 01:13:04AM -0700, Andrew Morton wrote:
> "H. Peter Anvin" wrote:
> >
> > Followup to: <3D58A45F.A7F5BDD@zip.com.au>
> > By author: Andrew Morton <akpm@zip.com.au>
> > In newsgroup: linux.dev.kernel
> >
> > > --- linux-2.5.31/include/linux/kernel.h Wed Jul 24 14:31:31 2002
> > > +++ 25/include/linux/kernel.h Mon Aug 12 23:09:31 2002
> > > @@ -13,6 +13,8 @@
> > > #include <linux/types.h>
> > > #include <linux/compiler.h>
> > >
> > > +#define __func__ __FUNCTION__ /* For old gcc's */
> > > +
> > > /* Optimization barrier */
> > > /* The "volatile" is due to gcc bugs */
> > > #define barrier() __asm__ __volatile__("": : :"memory")
> >
> > Shouldn't this be conditional on the version?
>
> Could be. But I don't know what version to use.
How about:
/* early gcc compilers lose on __func__ */
#ifndef __func__
#define __func__ __FUNCTION__
#endif /* !defined __func__ */
--
"Hmm.. Cache shrink failed - time to kill something?
Mhwahahhaha! This is the part I really like. Giggle."
-- linux/mm/vmscan.c
http://vipe.technion.ac.il/~mulix/ http://syscalltrack.sf.net
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2002-08-13 8:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-13 6:17 [patch] __func__ -> __FUNCTION__ Andrew Morton
2002-08-13 6:49 ` H. Peter Anvin
2002-08-13 8:13 ` Andrew Morton
2002-08-13 7:59 ` Muli Ben-Yehuda [this message]
2002-08-13 8:09 ` H. Peter Anvin
2002-08-13 8:10 ` Muli Ben-Yehuda
2002-08-13 8:19 ` H. Peter Anvin
2002-08-13 8:19 ` Muli Ben-Yehuda
2002-08-14 21:16 ` Maksim (Max) Krasnyanskiy
2002-08-13 8:20 ` Christoph Hellwig
2002-08-13 8:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020813075944.GA2192@alhambra.actcom.co.il \
--to=mulix@actcom.co.il \
--cc=akpm@zip.com.au \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox