From: Andrew Morton <akpm@zip.com.au>
To: Christoph Hellwig <hch@infradead.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] __func__ -> __FUNCTION__
Date: Tue, 13 Aug 2002 01:49:33 -0700 [thread overview]
Message-ID: <3D58C81D.4DAA3FBE@zip.com.au> (raw)
In-Reply-To: 20020813092043.A1859@infradead.org
Christoph Hellwig wrote:
>
> On Mon, Aug 12, 2002 at 11:17:03PM -0700, Andrew Morton wrote:
> >
> > It is a requirement of the SPARC port that Linux be compilable
> > by egcs-1.1.2, aka gcc-2.91.66.
> >
> > That compiler does not support __func__.
>
> Is there any reason to not use __FUNCTION__? According to the gcc folks
> that there is no plan to retire it, and as long as all known-good kernel
> compilers support it a gccism is a lot better than a standard feature that
> is not supported by most of the kernel compilers.
Sounds fine to me.
--- linux-2.5.31/include/linux/kernel.h Wed Jul 24 14:31:31 2002
+++ 25/include/linux/kernel.h Tue Aug 13 01:48:36 2002
@@ -13,6 +13,8 @@
#include <linux/types.h>
#include <linux/compiler.h>
+#define __func__ use.__FUNCTION__.not.__func__
+
/* Optimization barrier */
/* The "volatile" is due to gcc bugs */
#define barrier() __asm__ __volatile__("": : :"memory")
It affects
drivers/char/drm/mga_dma.c
drivers/char/drm/mga_drv.h
drivers/char/drm/mga_state.c
drivers/char/drm/r128_cce.c
drivers/char/drm/r128_drv.h
drivers/char/drm/r128_state.c
drivers/char/drm/radeon_cp.c
drivers/char/drm/radeon_drv.h
drivers/char/drm/radeon_state.c
include/net/bluetooth/bluetooth.h
prev parent reply other threads:[~2002-08-13 8:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-13 6:17 [patch] __func__ -> __FUNCTION__ Andrew Morton
2002-08-13 6:49 ` H. Peter Anvin
2002-08-13 8:13 ` Andrew Morton
2002-08-13 7:59 ` Muli Ben-Yehuda
2002-08-13 8:09 ` H. Peter Anvin
2002-08-13 8:10 ` Muli Ben-Yehuda
2002-08-13 8:19 ` H. Peter Anvin
2002-08-13 8:19 ` Muli Ben-Yehuda
2002-08-14 21:16 ` Maksim (Max) Krasnyanskiy
2002-08-13 8:20 ` Christoph Hellwig
2002-08-13 8:49 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D58C81D.4DAA3FBE@zip.com.au \
--to=akpm@zip.com.au \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox