From: Benjamin LaHaise <bcrl@redhat.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Alexander Viro <viro@math.psu.edu>,
Andrew Morton <akpm@zip.com.au>, "H. Peter Anvin" <hpa@zytor.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] printk from userspace
Date: Wed, 14 Aug 2002 00:48:06 -0400 [thread overview]
Message-ID: <20020814004806.B16322@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0208132142310.1208-100000@home.transmeta.com>; from torvalds@transmeta.com on Tue, Aug 13, 2002 at 09:44:14PM -0700
On Tue, Aug 13, 2002 at 09:44:14PM -0700, Linus Torvalds wrote:
> Actually, anybody who uses stdio on syslog messages should be roasted.
> Over the nice romantic glow of red-hot coal, slowly cooking the stupid git
> alive.
If you're logging huge messages, sure, that's just plain Stupid. But for
messages that are smaller than the size of the stdio buffer an fprintf()
followed by fflush() gets a single atomic write for most values of libc.
> It's not a bug, it's a feature. A syslog message needs to be atomic, which
> means that it MUST NOT use the buffering of stdio.
And that's why we have write(2) on file descriptors. Having write(2)
in the form of syslog(2) makes no sense. It adds to the mass of abi
that needs to be maintained. Making the mechanism of writing using the
existing infrastructure doesn't increase the size of the ABI.
-ben
--
"You will be reincarnated as a toad; and you will be much happier."
next prev parent reply other threads:[~2002-08-14 4:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-14 3:18 [patch] printk from userspace Andrew Morton
2002-08-14 3:58 ` Benjamin LaHaise
2002-08-14 4:00 ` H. Peter Anvin
2002-08-14 4:05 ` Benjamin LaHaise
2002-08-14 4:10 ` Alexander Viro
2002-08-14 4:11 ` Andrew Morton
2002-08-14 4:07 ` Benjamin LaHaise
2002-08-14 4:20 ` Alexander Viro
2002-08-14 4:26 ` Linus Torvalds
2002-08-14 4:35 ` Benjamin LaHaise
2002-08-14 4:42 ` H. Peter Anvin
2002-08-14 4:44 ` Linus Torvalds
2002-08-14 4:44 ` H. Peter Anvin
2002-08-14 4:48 ` Benjamin LaHaise [this message]
2002-08-14 4:58 ` Andrew Morton
2002-08-14 5:32 ` H. Peter Anvin
2002-08-19 11:28 ` Daniel Phillips
2002-08-14 7:59 ` Miquel van Smoorenburg
2002-08-14 16:12 ` serial console (was Re: [patch] printk from userspace) Arkadiusz Miskiewicz
2002-08-15 12:43 ` Miquel van Smoorenburg
2002-08-14 4:33 ` [patch] printk from userspace H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020814004806.B16322@redhat.com \
--to=bcrl@redhat.com \
--cc=akpm@zip.com.au \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox