Re: (RFC): SKB Initialization

[Benjamin LaHaise <bcrl@redhat.com>]

On Wed, Aug 21, 2002 at 11:59:44AM -0500, Mala Anand wrote:
> The patch reduces the numer of cylces by 25%

The data you are reporting is flawed: where are the average cycle 
times spent in __kfree_skb with the patch?  Without that information, 
there is no basis for conclusion as the total time spent in these 
two routines is unknown.  At worst, I'd have to assume this lack of 
scientific method is an attempt to hide some aspect of the resulting 
behaviour, but I hope that isn't the case.

		-ben

> Baseline on Linux 2.5.25 kernel:
> -------------------------------
> 
>                                 CPU 0                 CPU 1
>                                ------                 ------
> Avg cycles in alloc_skb:        64.05                 203.39
> Avg cycles in __kfree_skb:     127.54                 228.95
>                                ------                 -------
> Total Avg Cycles               191.59                 432.34
>                                ------                 -------
> 
> # of times alloc_skb called:      235,478            2,060,422
> # of times __kfree_skb called:  2,063,276              232,359
> 
> 
> Linux 2.5.25+Skbinit Patch:
> --------------------------
>                               CPU 0                   CPU 1
>                               -----                   -----
>  Avg cycles in alloc skb:     237.21                  230.91
> 
>  # of times alloc_skb called: 1,226,594             1,213,327