From: Benjamin LaHaise <bcrl@redhat.com>
To: Mala Anand <manand@us.ibm.com>
Cc: alan@lxorguk.ukuu.org.uk, Bill Hartner <bhartner@us.ibm.com>,
davem@redhat.com, linux-kernel@vger.kernel.org,
lse-tech@lists.sourceforge.net
Subject: Re: (RFC): SKB Initialization
Date: Wed, 21 Aug 2002 14:16:01 -0400 [thread overview]
Message-ID: <20020821141601.F8001@redhat.com> (raw)
In-Reply-To: <OF874EB8CD.B30B589E-ON87256C1C.00634F29@boulder.ibm.com>; from manand@us.ibm.com on Wed, Aug 21, 2002 at 01:07:09PM -0500
On Wed, Aug 21, 2002 at 01:07:09PM -0500, Mala Anand wrote:
>
> >On Wed, Aug 21, 2002 at 11:59:44AM -0500, Mala Anand wrote:
> >> The patch reduces the numer of cylces by 25%
>
> >The data you are reporting is flawed: where are the average cycle
> >times spent in __kfree_skb with the patch?
>
> I measured the cycles for only the initialization code in alloc_skb
> and __kfree_skb. Since the init code is removed from __kfree_skb,
> no cycles are spent there.
Then the testing technique is flawed. You should include all of the
operations included in an alloc_skb/kfree_skb pair in order to see
the overall effect of the change, otherwise your change could have a
net negative effect which would not be noticed.
-ben
--
"You will be reincarnated as a toad; and you will be much happier."
next prev parent reply other threads:[~2002-08-21 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-21 18:07 (RFC): SKB Initialization Mala Anand
2002-08-21 18:16 ` Benjamin LaHaise [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-08-21 18:42 Nivedita Singhvi
2002-08-21 16:59 Mala Anand
2002-08-21 17:10 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020821141601.F8001@redhat.com \
--to=bcrl@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bhartner@us.ibm.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=manand@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox