From: Andi Kleen <ak@muc.de>
To: Peter Chubb <peter@chubb.wattle.id.au>
Cc: "David S. Miller" <davem@redhat.com>,
ak@muc.de, akpm@digeo.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Add extended attributes to ext2/3
Date: Wed, 16 Oct 2002 16:01:53 +0200 [thread overview]
Message-ID: <20021016140153.GA8414@averell> (raw)
In-Reply-To: <15788.54887.251518.350350@wombat.chubb.wattle.id.au>
> There isn't as far as I know a flag I can test in a config.in file
> that distinguishes 64 from 32-bit architectures. The intention was to
> enable the choice of CONFIG_LBD where it made sense; it doesn't make
> sense for 64-bit architectures; and rather than enumerate all the
> 32-bit architectures, I just chose two that I knew were used in
> servers currently.
Then you got it wrong. CONFIG_X86 includes x86-64, which is 64bit.
Correct test for x86-32 would be something like
CONFIG_X86 && !CONFIG_X86_64
best way is to just define_bool it in the individual arch/*/config.in
Or alternatively add a CONFIG_64BIT to the 64bit architectures and
test for that.
-Andi
next parent reply other threads:[~2002-10-16 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <698528293@toto.iv>
[not found] ` <15788.54887.251518.350350@wombat.chubb.wattle.id.au>
2002-10-16 14:01 ` Andi Kleen [this message]
2002-10-15 22:20 [PATCH 1/3] Add extended attributes to ext2/3 tytso
2002-10-16 0:00 ` Andrew Morton
2002-10-16 0:11 ` Andreas Gruenbacher
2002-10-16 0:52 ` Andrew Morton
2002-10-16 1:20 ` Andi Kleen
2002-10-16 1:43 ` David S. Miller
2002-10-16 16:04 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021016140153.GA8414@averell \
--to=ak@muc.de \
--cc=akpm@digeo.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@chubb.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox