* [PATCH] Fix undeclared NULL in timer.h
@ 2002-11-04 7:32 Rusty Russell
2002-11-04 16:31 ` Denis Vlasenko
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2002-11-04 7:32 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, trivial
Uncovered on a PPC compile: timer.h uses NULL, so needs stddef.h
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .22822-2.5.45-bk-module-ppc.pre/include/linux/timer.h .22822-2.5.45-bk-module-ppc/include/linux/timer.h
--- .22822-2.5.45-bk-module-ppc.pre/include/linux/timer.h 2002-10-31 12:37:02.000000000 +1100
+++ .22822-2.5.45-bk-module-ppc/include/linux/timer.h 2002-11-04 18:28:53.000000000 +1100
@@ -3,6 +3,7 @@
#include <linux/config.h>
#include <linux/list.h>
+#include <linux/stddef.h>
struct tvec_t_base_s;
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix undeclared NULL in timer.h
2002-11-04 7:32 [PATCH] Fix undeclared NULL in timer.h Rusty Russell
@ 2002-11-04 16:31 ` Denis Vlasenko
2002-11-04 14:27 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Denis Vlasenko @ 2002-11-04 16:31 UTC (permalink / raw)
To: Rusty Russell, torvalds; +Cc: linux-kernel, trivial
On 4 November 2002 05:32, Rusty Russell wrote:
> Uncovered on a PPC compile: timer.h uses NULL, so needs stddef.h
>
> diff -urpN --exclude TAGS -X
> /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal
> .22822-2.5.45-bk-module-ppc.pre/include/linux/timer.h
> .22822-2.5.45-bk-module-ppc/include/linux/timer.h ---
> .22822-2.5.45-bk-module-ppc.pre/include/linux/timer.h 2002-10-31
> 12:37:02.000000000 +1100 +++
> .22822-2.5.45-bk-module-ppc/include/linux/timer.h 2002-11-04
> 18:28:53.000000000 +1100 @@ -3,6 +3,7 @@
>
> #include <linux/config.h>
> #include <linux/list.h>
> +#include <linux/stddef.h>
>
> struct tvec_t_base_s;
The whole problem of #include forest going out of control
needs some clever solution or we will eternally chase missing
.h files
--
vda
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix undeclared NULL in timer.h
2002-11-04 16:31 ` Denis Vlasenko
@ 2002-11-04 14:27 ` Dave Jones
0 siblings, 0 replies; 3+ messages in thread
From: Dave Jones @ 2002-11-04 14:27 UTC (permalink / raw)
To: Denis Vlasenko; +Cc: Rusty Russell, torvalds, linux-kernel
On Mon, Nov 04, 2002 at 02:31:39PM -0200, Denis Vlasenko wrote:
> The whole problem of #include forest going out of control
> needs some clever solution or we will eternally chase missing
> .h files
Doing an untangle at this point is pretty much a waste of effort.
As we get closer to stabilising, we can regenerate the dependancy
graphs and see what looks out of place again.
Adding lots of #include's isn't an issue as long as those includes
aren't sucking in 200 others.
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-11-04 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-11-04 7:32 [PATCH] Fix undeclared NULL in timer.h Rusty Russell
2002-11-04 16:31 ` Denis Vlasenko
2002-11-04 14:27 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox