The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: manfred@colorfullife.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fix slab allocator for non zero boot cpu
Date: Tue, 5 Nov 2002 16:49:48 +1100	[thread overview]
Message-ID: <20021105054948.GA10335@krispykreme> (raw)


Hi,

The slab allocator doesnt initialise ->array for all cpus. This means
we fail to boot on a machine with boot cpu != 0. I was testing current
2.5 BK.

Luckily Rusty was at hand to explain the ins and outs of initialisers
to me. Manfred, does this look OK to you?

Anton

===== mm/slab.c 1.46 vs edited =====
--- 1.46/mm/slab.c	Sat Nov  2 08:34:38 2002
+++ edited/mm/slab.c	Tue Nov  5 15:55:55 2002
@@ -437,7 +437,8 @@
 /* internal cache of cache description objs */
 static kmem_cache_t cache_cache = {
 	.lists		= LIST3_INIT(cache_cache.lists),
-	.array		= { [0] = &initarray_cache.cache },
+	/* Allow for boot cpu != 0 */
+	.array		= { [0 ... NR_CPUS-1] = &initarray_cache.cache },
 	.batchcount	= 1,
 	.limit		= BOOT_CPUCACHE_ENTRIES,
 	.objsize	= sizeof(kmem_cache_t),

             reply	other threads:[~2002-11-05  5:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-05  5:49 Anton Blanchard [this message]
2002-11-05 22:24 ` [PATCH] fix slab allocator for non zero boot cpu Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021105054948.GA10335@krispykreme \
    --to=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox