From: Manfred Spraul <manfred@colorfullife.com>
To: Anton Blanchard <anton@samba.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix slab allocator for non zero boot cpu
Date: Tue, 05 Nov 2002 23:24:15 +0100 [thread overview]
Message-ID: <3DC8450F.6000901@colorfullife.com> (raw)
In-Reply-To: 20021105054948.GA10335@krispykreme
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
Anton Blanchard wrote:
>Hi,
>
>The slab allocator doesnt initialise ->array for all cpus. This means
>we fail to boot on a machine with boot cpu != 0. I was testing current
>2.5 BK.
>
>Luckily Rusty was at hand to explain the ins and outs of initialisers
>to me. Manfred, does this look OK to you?
>
I don't like the patch - it removes the safety net.
initarray_cache is __initdata, and is replaced with actual data after
the kmalloc caches work, but only for the cpu that performed the
bootstrap (end of kmem_cache_sizes_init())
With your patch, the pointer to the head arrays of the other cpus still
point to an __initdata variable. It's even oopsable, if a
CPU_ONLINE_PREPARE is failed by another subsystem.
What about the attached patch?
--
Manfred
[-- Attachment #2: patch-other --]
[-- Type: application/x-java-applet, Size: 648 bytes --]
prev parent reply other threads:[~2002-11-05 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-05 5:49 [PATCH] fix slab allocator for non zero boot cpu Anton Blanchard
2002-11-05 22:24 ` Manfred Spraul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DC8450F.6000901@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox