From: Mike Anderson <andmike@us.ibm.com>
To: Petr Vandrovec <vandrove@vc.cvut.cz>
Cc: Matt_Domsch@Dell.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.50-current-bk and EDD
Date: Mon, 2 Dec 2002 11:01:14 -0800 [thread overview]
Message-ID: <20021202190114.GB1850@beaverton.ibm.com> (raw)
In-Reply-To: <20021202183619.GB9798@vana>
Petr Vandrovec [vandrove@vc.cvut.cz] wrote:
> Hi Matt,
> I'm not sure that this patch is correct, but at least I can
> compile kernel now. As I have no SCSI devices in the box, I have
> no idea whether this to_scsi_host() should do same thing as
> to_scsi_host() in drivers/scsi does...
> Thanks,
> Petr Vandrovec
>
>
>
> diff -urdN linux/arch/i386/kernel/edd.c linux/arch/i386/kernel/edd.c
> --- linux/arch/i386/kernel/edd.c 2002-12-02 17:28:11.000000000 +0000
> +++ linux/arch/i386/kernel/edd.c 2002-12-02 17:36:49.000000000 +0000
> @@ -686,8 +686,6 @@
> * The reference counting probably isn't the best it could be.
> */
>
> -#define to_scsi_host(d) \
> - container_of(d, struct Scsi_Host, host_driverfs_dev)
> #define children_to_dev(n) container_of(n,struct device,node)
> static struct scsi_device *
> edd_find_matching_scsi_device(struct edd_device *edev)
This is my bad with some sysfs updates I did recently to scsi. The patch
will make you compile, but the to_scsi_host is host.h does not return the
same data as the previous to_scsi_host in edd.c did if class_data is not
set. Though the "sh" variable is never used in the function
edd_find_matching_scsi_device. I will look over this function some more
and send mail to the list / Matt as to what else might have broke.
-andmike
--
Michael Anderson
andmike@us.ibm.com
prev parent reply other threads:[~2002-12-02 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-02 18:36 [PATCH] 2.5.50-current-bk and EDD Petr Vandrovec
2002-12-02 19:01 ` Mike Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021202190114.GB1850@beaverton.ibm.com \
--to=andmike@us.ibm.com \
--cc=Matt_Domsch@Dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox