public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: <niteowl@intrinsity.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.59 kernel bugs
Date: Thu, 6 Feb 2003 13:16:40 -0800	[thread overview]
Message-ID: <20030206131640.2e668374.akpm@digeo.com> (raw)
In-Reply-To: <200302062043.h16KhHY05212@bletchley.vert.intrinsity.com>

<niteowl@intrinsity.com> wrote:
>
> FWIW, here's a list of potential 2.5.59 kernel bugs.  Some of these
> might be causing real trouble. Many are probably benign.  A few may be
> non-bugs that are just poor coding style although I've tried to weed

I assume you picked these up with `gcc -W'?

gcc -W generates ten megabytes of warnings, with a few gems.  We really need
finer-grained control of gcc warnings so that the good ones can be turned on.
gcc warnings are being redone at present and this might yet happen...

> fs/super.c:313				if (!sb->s_op->sync_fs);

That's fixed in 2.5.59++

> net/ipv4/fib_hash.c:944			if (iter->zone->fz_next);

That too.  davem said "OMG that's scary :)"

> fs/hugetlbfs/inode.c:235		if (!super_block | (super_block->s_flags & MS_ACTIVE)) {

I'll fix that up.

As for the rest well gee.  Perhaps we should stick #error's in there to
flush out some people who can test the fixes.


  parent reply	other threads:[~2003-02-06 21:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-06 20:43 2.5.59 kernel bugs niteowl
2003-02-06 21:08 ` Martin J. Bligh
2003-02-06 23:16   ` Alan Cox
2003-02-06 22:33     ` Martin J. Bligh
2003-02-06 21:16 ` Andrew Morton [this message]
2003-02-06 22:49   ` Dave Jones
2003-02-06 23:06     ` Randy.Dunlap
2003-02-28  9:14       ` Paul Laufer
2003-02-07  0:14 ` Russell King
2003-02-07  9:23 ` Oleg Drokin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030206131640.2e668374.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niteowl@intrinsity.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox