From: Oleg Drokin <green@namesys.com>
To: niteowl@intrinsity.com
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
andre@linux-ide.org, axboe@suse.de
Subject: Re: 2.5.59 kernel bugs
Date: Fri, 7 Feb 2003 12:23:57 +0300 [thread overview]
Message-ID: <20030207122357.A30922@namesys.com> (raw)
In-Reply-To: <200302062043.h16KhHY05212@bletchley.vert.intrinsity.com>
Hello!
On Thu, Feb 06, 2003 at 02:43:17PM -0600, niteowl@intrinsity.com wrote:
Also similar stuff in IDE code in 2.4.21-pre4 from bk tree:
> ===== misplaced/extra semicolon =====
drivers/ide/ide-taskfile.c:247 if (drive->using_dma && !(hwif->ide_dma_write(drive)));
drivers/ide/ide-taskfile.c:253 if (drive->using_dma && !(hwif->ide_dma_read(drive)));
At least looking at another similar code that is ifdefed out, it seems below patch is correct.
(and even if it's not, still that code should be changed not to confuse people ;) )
Also I took a look at drivers/ide/ide-taskfile.c in 2.5 hoping I can see what should
be in fact done and got even more confused ;)
Sounds like in 2.5 there should be "return ide_started" at the end, not stopped,
because otherwise when drive->using_dma is set, we always return ide_stopped for
WIN_WRITEDMA.*, WIN_IDENTIFY_DMA and WIN_READDMA, WIN_READDMA_ONCE, WIN_READDMA_EXT
taskfile->command and default case is the same (we check stuff, and then regardless
or the result of the check we always return ide_stopped).
Which looks somehow strange (and different from similar code in 2.4).
Can please somebody take a look at it?
Bye,
Oleg
===== drivers/ide/ide-taskfile.c 1.2 vs edited =====
--- 1.2/drivers/ide/ide-taskfile.c Thu Nov 14 20:38:17 2002
+++ edited/drivers/ide/ide-taskfile.c Fri Feb 7 11:56:59 2003
@@ -244,13 +244,13 @@
case WIN_WRITEDMA_ONCE:
case WIN_WRITEDMA:
case WIN_WRITEDMA_EXT:
- if (drive->using_dma && !(hwif->ide_dma_write(drive)));
+ if (drive->using_dma && !(hwif->ide_dma_write(drive)))
return ide_started;
case WIN_READDMA_ONCE:
case WIN_READDMA:
case WIN_READDMA_EXT:
case WIN_IDENTIFY_DMA:
- if (drive->using_dma && !(hwif->ide_dma_read(drive)));
+ if (drive->using_dma && !(hwif->ide_dma_read(drive)))
return ide_started;
default:
break;
prev parent reply other threads:[~2003-02-07 9:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-06 20:43 2.5.59 kernel bugs niteowl
2003-02-06 21:08 ` Martin J. Bligh
2003-02-06 23:16 ` Alan Cox
2003-02-06 22:33 ` Martin J. Bligh
2003-02-06 21:16 ` Andrew Morton
2003-02-06 22:49 ` Dave Jones
2003-02-06 23:06 ` Randy.Dunlap
2003-02-28 9:14 ` Paul Laufer
2003-02-07 0:14 ` Russell King
2003-02-07 9:23 ` Oleg Drokin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030207122357.A30922@namesys.com \
--to=green@namesys.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=niteowl@intrinsity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox