From: Alexander Viro <viro@math.psu.edu>
To: Andries Brouwer <aebr@win.tue.nl>
Cc: Roman Zippel <zippel@linux-m68k.org>,
Christoph Hellwig <hch@infradead.org>,
Dave Jones <davej@codemonkey.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fwd: struct inode size reduction.
Date: Sun, 9 Mar 2003 21:23:41 -0500 [thread overview]
Message-ID: <20030309212341.A29753@math.psu.edu> (raw)
In-Reply-To: <20030309230824.GA3842@win.tue.nl>; from aebr@win.tue.nl on Mon, Mar 10, 2003 at 12:08:24AM +0100
On Mon, Mar 10, 2003 at 12:08:24AM +0100, Andries Brouwer wrote:
> =====
> +int register_chrdev(unsigned int major, const char *name,
> + struct file_operations *fops)
> +{
> + return register_chrdev_region(major, 0, 256, name, fops);
> +}
That's Wrong API(tm). Why do you need to keep separation between
major and first minor? Just pass dev_t start and unsigned len.
BTW, I'd like to take a look at your CIDR for chrdev - I've got one
to resurrect and it might make sense to compare-and-merge. And
yes, I'm finally back - hopefully for good.
next prev parent reply other threads:[~2003-03-10 2:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-09 13:54 Fwd: struct inode size reduction Dave Jones
2003-03-09 17:13 ` Andries Brouwer
2003-03-09 20:33 ` Dave Jones
2003-03-09 19:55 ` Christoph Hellwig
2003-03-09 20:31 ` Andries Brouwer
2003-03-09 22:18 ` Roman Zippel
2003-03-09 23:08 ` Andries Brouwer
2003-03-10 2:23 ` Alexander Viro [this message]
2003-03-10 10:58 ` Roman Zippel
2003-03-10 12:05 ` Andries Brouwer
2003-03-10 16:25 ` Roman Zippel
2003-03-10 17:32 ` Andries Brouwer
2003-03-10 18:39 ` Roman Zippel
2003-03-09 22:45 ` J.A. Magallon
2003-03-10 0:11 ` Dave Jones
2003-03-09 23:59 ` J.A. Magallon
2003-03-10 5:04 ` Miles Bader
-- strict thread matches above, loose matches on Subject: below --
2003-03-10 9:30 Fwd: " Andries.Brouwer
2003-03-10 9:32 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030309212341.A29753@math.psu.edu \
--to=viro@math.psu.edu \
--cc=aebr@win.tue.nl \
--cc=davej@codemonkey.org.uk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox