public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.5 patch] fix drivers/i2c/scx200_i2c.c compilation
@ 2003-04-08 11:36 Adrian Bunk
  2003-04-08 21:51 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2003-04-08 11:36 UTC (permalink / raw)
  To: Christer Weinigel, linux-i2c; +Cc: linux-kernel, trivial

I got the following compile error in 2.5.67:

<--  snip  -->

...
  gcc -Wp,-MD,drivers/i2c/.scx200_i2c.o.d -D__KERNEL__ -Iinclude -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe 
-mpreferred-stack-boundary=2 -march=k6 -Iinclude/asm-i386/mach-default -nostdinc 
-iwithprefix include    -DKBUILD_BASENAME=scx200_i2c -DKBUILD_MODNAME=scx200_i2c 
-c -o drivers/i2c/scx200_i2c.o drivers/i2c/scx200_i2c.c
drivers/i2c/scx200_i2c.c:85: unknown field `name' specified in initializer
drivers/i2c/scx200_i2c.c:85: warning: initialization makes integer from 
pointer without a cast
drivers/i2c/scx200_i2c.c: In function `scx200_i2c_init':
drivers/i2c/scx200_i2c.c:113: structure has no member named `name'
make[2]: *** [drivers/i2c/scx200_i2c.o] Error 1


<--  snip  -->


The following patch is needed:

--- linux-2.5.67-notfull/drivers/i2c/scx200_i2c.c.old	2003-04-08 13:04:22.000000000 +0200
+++ linux-2.5.67-notfull/drivers/i2c/scx200_i2c.c	2003-04-08 13:07:14.000000000 +0200
@@ -82,9 +82,11 @@
 
 static struct i2c_adapter scx200_i2c_ops = {
 	.owner		   = THIS_MODULE,
-	.name              = "NatSemi SCx200 I2C",
 	.id		   = I2C_HW_B_VELLE,
 	.algo_data	   = &scx200_i2c_data,
+	.dev		   = {
+		.name	   = "NatSemi SCx200 I2C",
+	},
 };
 
 int scx200_i2c_init(void)
@@ -110,7 +112,7 @@
 
 	if (i2c_bit_add_bus(&scx200_i2c_ops) < 0) {
 		printk(KERN_ERR NAME ": adapter %s registration failed\n", 
-		       scx200_i2c_ops.name);
+		       scx200_i2c_ops.dev.name);
 		return -ENODEV;
 	}
 	


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.5 patch] fix drivers/i2c/scx200_i2c.c compilation
  2003-04-08 11:36 [2.5 patch] fix drivers/i2c/scx200_i2c.c compilation Adrian Bunk
@ 2003-04-08 21:51 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2003-04-08 21:51 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Christer Weinigel, linux-i2c, linux-kernel, trivial

On Tue, Apr 08, 2003 at 01:36:46PM +0200, Adrian Bunk wrote:
> I got the following compile error in 2.5.67:
> 
> <--  snip  -->

Thanks, I just added this to my tree yesterday :)
I'll send it on to Linus in a bit.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-04-08 22:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-04-08 11:36 [2.5 patch] fix drivers/i2c/scx200_i2c.c compilation Adrian Bunk
2003-04-08 21:51 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox