* link error building kernel with gcc-3.3
@ 2003-05-14 20:29 Alex Davis
2003-05-15 5:38 ` James Morris
0 siblings, 1 reply; 5+ messages in thread
From: Alex Davis @ 2003-05-14 20:29 UTC (permalink / raw)
To: linux-kernel
I got the following linking 2.4.21rc1:
net/network.o(.text+0xdcb7): In function `rtnetlink_rcv':
: undefined reference to `rtnetlink_rcv_skb'
make: *** [vmlinux] Error 1
Removing '__inline__' from the definition of rtnetlink_rcv_skb
in net/core/rtnetlink.c fixed the problem.
Note: this error also occurs in 2.4.21rc2-ac2
__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: link error building kernel with gcc-3.3
2003-05-14 20:29 link error building kernel with gcc-3.3 Alex Davis
@ 2003-05-15 5:38 ` James Morris
2003-05-15 5:42 ` David S. Miller
0 siblings, 1 reply; 5+ messages in thread
From: James Morris @ 2003-05-15 5:38 UTC (permalink / raw)
To: Alex Davis; +Cc: linux-kernel, netdev
On Wed, 14 May 2003, Alex Davis wrote:
> I got the following linking 2.4.21rc1:
>
> net/network.o(.text+0xdcb7): In function `rtnetlink_rcv':
> : undefined reference to `rtnetlink_rcv_skb'
> make: *** [vmlinux] Error 1
>
> Removing '__inline__' from the definition of rtnetlink_rcv_skb
> in net/core/rtnetlink.c fixed the problem.
>
> Note: this error also occurs in 2.4.21rc2-ac2
I wonder, does this mean that the compiler failed to inline the function?
Removing __inline__ is not the correct solution.
- James
--
James Morris
<jmorris@intercode.com.au>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: link error building kernel with gcc-3.3
2003-05-15 5:38 ` James Morris
@ 2003-05-15 5:42 ` David S. Miller
2003-05-15 14:56 ` Alex Davis
0 siblings, 1 reply; 5+ messages in thread
From: David S. Miller @ 2003-05-15 5:42 UTC (permalink / raw)
To: jmorris; +Cc: alex14641, linux-kernel, netdev
From: James Morris <jmorris@intercode.com.au>
Date: Thu, 15 May 2003 15:38:15 +1000 (EST)
I wonder, does this mean that the compiler failed to inline the function?
Removing __inline__ is not the correct solution.
I already posted what the correct fix is :-) And this is already
pushed to 2.5.x
Inlining is not guarenteed, and:
extern inline ... foo(...)
means "inline if you can, I have a compiled-in implementation
in some object somewhere" whereas:
static inline ... foo(...)
means "inline if you can, if there is a case where you cannot
emit this as a function into the current module"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: link error building kernel with gcc-3.3
2003-05-15 5:42 ` David S. Miller
@ 2003-05-15 14:56 ` Alex Davis
2003-05-15 20:11 ` David S. Miller
0 siblings, 1 reply; 5+ messages in thread
From: Alex Davis @ 2003-05-15 14:56 UTC (permalink / raw)
To: David S. Miller, jmorris; +Cc: alex14641, linux-kernel, netdev
Can you push it to 2.4.x as well?
-Alex
--- "David S. Miller" <davem@redhat.com> wrote:
> From: James Morris <jmorris@intercode.com.au>
> Date: Thu, 15 May 2003 15:38:15 +1000 (EST)
>
> I wonder, does this mean that the compiler failed to inline the function?
>
> Removing __inline__ is not the correct solution.
>
> I already posted what the correct fix is :-) And this is already
> pushed to 2.5.x
__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-05-15 20:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-14 20:29 link error building kernel with gcc-3.3 Alex Davis
2003-05-15 5:38 ` James Morris
2003-05-15 5:42 ` David S. Miller
2003-05-15 14:56 ` Alex Davis
2003-05-15 20:11 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox