From: Andrew Morton <akpm@digeo.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: alan@lxorguk.ukuu.org.uk, zwane@linuxpower.ca,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xirc2ps_cs irq return fix
Date: Mon, 26 May 2003 20:55:48 -0700 [thread overview]
Message-ID: <20030526205548.4853c92b.akpm@digeo.com> (raw)
In-Reply-To: <3ED2E03E.80004@pobox.com>
Jeff Garzik <jgarzik@pobox.com> wrote:
>
> If the fix is correct, we need to do a bombing run that adds the
> following code to each driver,
>
> if (!netif_device_present(dev))
> return IRQ_HANDLED;
no... What we need to do is to kill the printk in handle_IRQ_event().
It should only be turned on for special situations, where someone is trying
to hunt down a reproducible lockup. These are situations in which the odd
false positive just doesn't matter. And we know that there will always
be false positives due to apic delivery latency (at least).
I think the time is right to do this. Add CONFIG_DEBUG_IRQ and get on with
fixing real stuff.
next prev parent reply other threads:[~2003-05-27 3:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200305252318.h4PNIPX4026812@hera.kernel.org>
2003-05-26 0:44 ` [PATCH] xirc2ps_cs irq return fix Jeff Garzik
2003-05-26 1:00 ` Zwane Mwaikambo
2003-05-26 23:35 ` Alan Cox
2003-05-27 3:49 ` Jeff Garzik
2003-05-27 3:55 ` Andrew Morton [this message]
2003-05-27 9:40 ` Alan Cox
2003-05-27 10:45 ` Andrew Morton
2003-05-27 10:40 ` Alan Cox
2003-05-27 19:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030526205548.4853c92b.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox