From: Jeff Garzik <jgarzik@pobox.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@digeo.com>
Subject: Re: [PATCH] xirc2ps_cs irq return fix
Date: Sun, 25 May 2003 20:44:01 -0400 [thread overview]
Message-ID: <3ED16351.7060904@pobox.com> (raw)
In-Reply-To: <200305252318.h4PNIPX4026812@hera.kernel.org>
Linux Kernel Mailing List wrote:
> diff -Nru a/drivers/net/pcmcia/xirc2ps_cs.c b/drivers/net/pcmcia/xirc2ps_cs.c
> --- a/drivers/net/pcmcia/xirc2ps_cs.c Sun May 25 16:18:34 2003
> +++ b/drivers/net/pcmcia/xirc2ps_cs.c Sun May 25 16:18:34 2003
> if (!netif_device_present(dev))
> - return IRQ_NONE;
> + return IRQ_HANDLED;
As I mentioned in the thread, this piece of code is obviously wrong.
Think about how scalable this fix is?? Do you really want to crap up
all pcmcia drivers with this silly -- and wrong -- check?
IIRC the pcmcia layer or new irqreturn_t was blamed for the problem.
Come on. Linux mantra is -against- papering over bugs.
Jeff
next parent reply other threads:[~2003-05-26 0:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200305252318.h4PNIPX4026812@hera.kernel.org>
2003-05-26 0:44 ` Jeff Garzik [this message]
2003-05-26 1:00 ` [PATCH] xirc2ps_cs irq return fix Zwane Mwaikambo
2003-05-26 23:35 ` Alan Cox
2003-05-27 3:49 ` Jeff Garzik
2003-05-27 3:55 ` Andrew Morton
2003-05-27 9:40 ` Alan Cox
2003-05-27 10:45 ` Andrew Morton
2003-05-27 10:40 ` Alan Cox
2003-05-27 19:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ED16351.7060904@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox