2.5.70-bk[56] breaks disk partitioning with multiple IDE disks

2.5.70-bk[56] breaks disk partitioning with multiple IDE disks

[Adam J. Richter]

	Disk partition under linux-2.5.70-bk[56] systems with two
IDE disks is broken.  Under these kernels, the first disk gets
the partitioning of the second disk.  Reverting drivers/ide/ide.c
to the 2.5.70-bk4 version makes the problem go away.

	However, there were other changes made to ide.c that are
probably not related to this problem, and I haven't yet analyzed the
problem enough to suggest a potentially correct patch.

	Note that I use user-level disk partition table parsing via
partx from util-linux and run ide as a loadable module.  It is
possible that other configuations might not experience this problem.

Adam J. Richter     __     ______________   575 Oroville Road
adam@yggdrasil.com     \ /                  Miplitas, California 95035
+1 408 309-6081         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."

[FIX] Re: 2.5.70-bk[56] breaks disk partitioning with multiple IDE disks

[viro]

On Sun, Jun 01, 2003 at 03:59:02PM -0700, Adam J. Richter wrote:
> 	Disk partition under linux-2.5.70-bk[56] systems with two
> IDE disks is broken.  Under these kernels, the first disk gets
> the partitioning of the second disk.  Reverting drivers/ide/ide.c
> to the 2.5.70-bk4 version makes the problem go away.

vi drivers/ide/ide.c -c'/drive->list.*driver->drives/s/list_add/&_tail/|x'

Now that we use idedefault_driver.drives instead of ata_unused, the order
of drives on the driver->drives becomes significant; note that when we added
to ata_unused, we had done that to the end of list.

Re: [FIX] Re: 2.5.70-bk[56] breaks disk partitioning with multiple IDE disks

[Linus Torvalds]

On Mon, 2 Jun 2003 viro@parcelfarce.linux.theplanet.co.uk wrote:
> 
> vi drivers/ide/ide.c -c'/drive->list.*driver->drives/s/list_add/&_tail/|x'

Mind sending me a patch? There's only so much I like doing with vi 
scripts, and this went over my threshold.

		Linus

Re: [FIX] Re: 2.5.70-bk[56] breaks disk partitioning with multiple IDE disks

[viro]

On Sun, Jun 01, 2003 at 06:49:41PM -0700, Linus Torvalds wrote:
> 
> On Mon, 2 Jun 2003 viro@parcelfarce.linux.theplanet.co.uk wrote:
> > 
> > vi drivers/ide/ide.c -c'/drive->list.*driver->drives/s/list_add/&_tail/|x'
> 
> Mind sending me a patch? There's only so much I like doing with vi 
> scripts, and this went over my threshold.

No problem...

--- drivers/ide/ide.c	Sat May 31 15:31:08 2003
+++ /tmp/ide.c	Sun Jun  1 19:50:38 2003
@@ -2335,7 +2335,7 @@
 	setup_driver_defaults(drive);
 	spin_unlock_irqrestore(&ide_lock, flags);
 	spin_lock(&drives_lock);
-	list_add(&drive->list, &driver->drives);
+	list_add_tail(&drive->list, &driver->drives);
 	spin_unlock(&drives_lock);
 //	printk(KERN_INFO "%s: attached %s driver.\n", drive->name, driver->name);
 	if ((drive->autotune == IDE_TUNE_DEFAULT) ||