From: Jeff Garzik <jgarzik@pobox.com>
To: davej@redhat.com
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org, jgarzik@redhat.com
Subject: Re: [PATCH] misc 3c505 bits
Date: Mon, 11 Aug 2003 10:49:33 -0400 [thread overview]
Message-ID: <20030811144933.GC32180@gtf.org> (raw)
In-Reply-To: <E19mCuP-0003dp-00@tetrachloride>
On Mon, Aug 11, 2003 at 02:40:25PM +0100, davej@redhat.com wrote:
> - Remove unneeded breaks
> - Fix double spin_unlock_irqrestore problem
>
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/3c505.c linux-2.5/drivers/net/3c505.c
> --- bk-linus/drivers/net/3c505.c 2003-05-26 12:57:43.000000000 +0100
> +++ linux-2.5/drivers/net/3c505.c 2003-06-04 14:07:40.000000000 +0100
> @@ -449,18 +449,18 @@ static int send_pcb(struct net_device *d
> case ASF_PCB_ACK:
> adapter->send_pcb_semaphore = 0;
> return TRUE;
> - break;
> +
> case ASF_PCB_NAK:
> #ifdef ELP_DEBUG
> printk(KERN_DEBUG "%s: send_pcb got NAK\n", dev->name);
> #endif
> goto abort;
> - break;
Disagree: borks message. You receive an ACK, and print "got NAK".
Jeff
next prev parent reply other threads:[~2003-08-11 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-11 13:40 [PATCH] misc 3c505 bits davej
2003-08-11 14:49 ` Jeff Garzik [this message]
2003-08-11 14:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030811144933.GC32180@gtf.org \
--to=jgarzik@pobox.com \
--cc=davej@redhat.com \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox