From: davej@redhat.com
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, jgarzik@redhat.com
Subject: [PATCH] misc 3c505 bits
Date: Mon, 11 Aug 2003 14:40:25 +0100 [thread overview]
Message-ID: <E19mCuP-0003dp-00@tetrachloride> (raw)
- Remove unneeded breaks
- Fix double spin_unlock_irqrestore problem
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/3c505.c linux-2.5/drivers/net/3c505.c
--- bk-linus/drivers/net/3c505.c 2003-05-26 12:57:43.000000000 +0100
+++ linux-2.5/drivers/net/3c505.c 2003-06-04 14:07:40.000000000 +0100
@@ -449,18 +449,18 @@ static int send_pcb(struct net_device *d
case ASF_PCB_ACK:
adapter->send_pcb_semaphore = 0;
return TRUE;
- break;
+
case ASF_PCB_NAK:
#ifdef ELP_DEBUG
printk(KERN_DEBUG "%s: send_pcb got NAK\n", dev->name);
#endif
goto abort;
- break;
}
}
if (elp_debug >= 1)
printk(KERN_DEBUG "%s: timeout waiting for PCB acknowledge (status %02x)\n", dev->name, inb_status(dev->base_addr));
+ goto abort;
sti_abort:
spin_unlock_irqrestore(&adapter->lock, flags);
next reply other threads:[~2003-08-11 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-11 13:40 davej [this message]
2003-08-11 14:49 ` [PATCH] misc 3c505 bits Jeff Garzik
2003-08-11 14:50 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E19mCuP-0003dp-00@tetrachloride \
--to=davej@redhat.com \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox