From: Dave Jones <davej@redhat.com>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: agpgart's MODULE_ALIAS is broken
Date: Tue, 16 Sep 2003 12:48:12 +0100 [thread overview]
Message-ID: <20030916114812.GB8753@redhat.com> (raw)
In-Reply-To: <200309161141.h8GBfqZv012047@harpo.it.uu.se>
On Tue, Sep 16, 2003 at 01:41:52PM +0200, Mikael Pettersson wrote:
> With 2.6.0-test5, the generated alias for agpgart
> in modules.alias looks wrong:
>
> alias char-major-10-AGPGART_MINOR agpgart
>
> Surely that should be char-major-10-175.
>
> The problem is that AGP's MODULE_ALIAS_MISCDEV() is in
> backend.c, but AGPGART_MINOR isn't #define:d there
> because agpgart.h is only #include:d in frontend.c.
> This causes MODULE_ALIAS_MISCDEV()'s __stringify()
> to convert the token itself rather than its value.
>
> Should be easy to fix (move the ALIAS or add #include).
Should be fixed in agpgart bk tree. I'm waiting on Linus
to return before I push updates..
Dave
--
Dave Jones http://www.codemonkey.org.uk
prev parent reply other threads:[~2003-09-16 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-16 11:41 agpgart's MODULE_ALIAS is broken Mikael Pettersson
2003-09-16 11:48 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030916114812.GB8753@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox