* agpgart's MODULE_ALIAS is broken
@ 2003-09-16 11:41 Mikael Pettersson
2003-09-16 11:48 ` Dave Jones
0 siblings, 1 reply; 2+ messages in thread
From: Mikael Pettersson @ 2003-09-16 11:41 UTC (permalink / raw)
To: davej; +Cc: linux-kernel
Dave,
With 2.6.0-test5, the generated alias for agpgart
in modules.alias looks wrong:
alias char-major-10-AGPGART_MINOR agpgart
Surely that should be char-major-10-175.
The problem is that AGP's MODULE_ALIAS_MISCDEV() is in
backend.c, but AGPGART_MINOR isn't #define:d there
because agpgart.h is only #include:d in frontend.c.
This causes MODULE_ALIAS_MISCDEV()'s __stringify()
to convert the token itself rather than its value.
Should be easy to fix (move the ALIAS or add #include).
/Mikael
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: agpgart's MODULE_ALIAS is broken
2003-09-16 11:41 agpgart's MODULE_ALIAS is broken Mikael Pettersson
@ 2003-09-16 11:48 ` Dave Jones
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2003-09-16 11:48 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: linux-kernel
On Tue, Sep 16, 2003 at 01:41:52PM +0200, Mikael Pettersson wrote:
> With 2.6.0-test5, the generated alias for agpgart
> in modules.alias looks wrong:
>
> alias char-major-10-AGPGART_MINOR agpgart
>
> Surely that should be char-major-10-175.
>
> The problem is that AGP's MODULE_ALIAS_MISCDEV() is in
> backend.c, but AGPGART_MINOR isn't #define:d there
> because agpgart.h is only #include:d in frontend.c.
> This causes MODULE_ALIAS_MISCDEV()'s __stringify()
> to convert the token itself rather than its value.
>
> Should be easy to fix (move the ALIAS or add #include).
Should be fixed in agpgart bk tree. I'm waiting on Linus
to return before I push updates..
Dave
--
Dave Jones http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-16 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-16 11:41 agpgart's MODULE_ALIAS is broken Mikael Pettersson
2003-09-16 11:48 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox