From: Christoph Hellwig <hch@infradead.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] s390 (2/7): common i/o layer.
Date: Mon, 6 Oct 2003 15:44:51 +0100 [thread overview]
Message-ID: <20031006154451.A20620@infradead.org> (raw)
In-Reply-To: <OF0C1219E4.69DD3439-ONC1256DB7.004E702C-C1256DB7.00509377@de.ibm.com>; from schwidefsky@de.ibm.com on Mon, Oct 06, 2003 at 04:40:06PM +0200
On Mon, Oct 06, 2003 at 04:40:06PM +0200, Martin Schwidefsky wrote:
>
> Hi Christoph,
>
> > Eek. How is the dummy release function supposed to help
> > anything? you must free the object in ->release. Also
> > the assignment is horrible as hell.
>
> Just checked. You right about chp_release which should do
> a kfree on the struct channel_path object. But the two
> other release functions are really dummy functions because
> cu3088_root_dev and iucv_root are static structures.
Even in that case you're screwed in case they are in modules..
next prev parent reply other threads:[~2003-10-06 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-06 14:40 [PATCH] s390 (2/7): common i/o layer Martin Schwidefsky
2003-10-06 14:44 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-10-06 15:59 Martin Schwidefsky
2003-10-06 15:37 Martin Schwidefsky
2003-10-06 15:46 ` viro
2003-10-06 14:49 Martin Schwidefsky
2003-10-06 14:55 ` Christoph Hellwig
2003-10-06 9:24 Martin Schwidefsky
2003-10-06 14:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031006154451.A20620@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox